* [PATCH v2] backports: add header file for function memcmp
@ 2018-08-22 3:06 Winnie Chang
2018-08-22 7:18 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Winnie Chang @ 2018-08-22 3:06 UTC (permalink / raw)
To: backports; +Cc: Chi-Hsien.Lin
Function memcmp is implicit declaration on kernel 4.9.88 ARM platform.
backport-include/keys/asymmetric-type.h uses function memcmp but its
caller compat/verification/verify.c and all its related header files
do not include string.h. The header file is usually included from
arch/arm/include/asm, but in this configuration, it doesn't. We need
to be safe and insure string.h is there.
Signed-off-by: Winnie Chang <winnie.chang@cypress.com>
---
backport/backport-include/keys/asymmetric-type.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/backport/backport-include/keys/asymmetric-type.h b/backport/backport-include/keys/asymmetric-type.h
index ee9c418..5744de9 100644
--- a/backport/backport-include/keys/asymmetric-type.h
+++ b/backport/backport-include/keys/asymmetric-type.h
@@ -2,6 +2,8 @@
#define __BP_ASYMMETRIC_TYPE_H
#ifdef CPTCFG_BPAUTO_BUILD_SYSTEM_DATA_VERIFICATION
+#include <linux/string.h>
+
struct asymmetric_key_id {
unsigned short len;
unsigned char data[];
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe backports" in
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] backports: add header file for function memcmp
2018-08-22 3:06 [PATCH v2] backports: add header file for function memcmp Winnie Chang
@ 2018-08-22 7:18 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2018-08-22 7:18 UTC (permalink / raw)
To: Winnie Chang, backports; +Cc: Chi-Hsien.Lin
On Tue, 2018-08-21 at 22:06 -0500, Winnie Chang wrote:
> Function memcmp is implicit declaration on kernel 4.9.88 ARM platform.
> backport-include/keys/asymmetric-type.h uses function memcmp but its
> caller compat/verification/verify.c and all its related header files
> do not include string.h. The header file is usually included from
> arch/arm/include/asm, but in this configuration, it doesn't. We need
> to be safe and insure string.h is there.
Makes sense, thanks!
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-22 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-22 3:06 [PATCH v2] backports: add header file for function memcmp Winnie Chang
2018-08-22 7:18 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).