Backports Archive on lore.kernel.org
 help / color / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: Hauke Mehrtens <hauke@hauke-m.de>, backports@vger.kernel.org
Subject: Re: [PATCH 13/14] backport: convert int led activate op to void when needed
Date: Mon, 24 Sep 2018 12:24:03 +0300
Message-ID: <948ce87ddf7b135e98506a2f0f2d56d9ccb43228.camel@coelho.fi> (raw)
In-Reply-To: <1aadb207-75fa-83e6-d838-2ac878b1c7c8@hauke-m.de>

On Sun, 2018-09-23 at 14:30 +0200, Hauke Mehrtens wrote:
> On 09/20/2018 01:28 PM, Luca Coelho wrote:
> > From: Luca Coelho <luciano.coelho@intel.com>
> > 
> > In kernel v4.19-rc1, the activate op in struct led_trigger, changed
> > from void to int.  To solve this, add a semantic patch to insert a
> > wrapper function that returns void and calls the function that
> > returns
> > int.
> > 
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > ---
> >  patches/led_activate.cocci | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 patches/led_activate.cocci
> > 
> > diff --git a/patches/led_activate.cocci
> > b/patches/led_activate.cocci
> > new file mode 100644
> > index 000000000000..df8211d29462
> > --- /dev/null
> > +++ b/patches/led_activate.cocci
> > @@ -0,0 +1,24 @@
> > +@act@
> > +identifier activate_fn, p;
> > +identifier m =~ "rx_led|tx_led|assoc_led|radio_led|tpt_led";
> > +fresh identifier activate_fn_wrap = "bp_" ## activate_fn;
> > +@@
> > +<...
> > ++#if LINUX_VERSION_IS_GEQ(4,19,0)
> > +p->m.activate = activate_fn;
> > ++#else
> > ++p->m.activate = activate_fn_wrap;
> > ++#endif
> > +...>
> 
> Please use <+--- ---+> here it improves the speed by some magnitudes.

Thanks for pointing out.  I remember the discussion about this with
Julia.  Johannes already fixed this in-place before applying my patch.

--
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe backports" in

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 11:28 [PATCH 00/14] backport: updates for 4.19 Luca Coelho
2018-09-20 11:28 ` [PATCH 01/14] backport: fix compilation with IPV6 not set Luca Coelho
2018-09-20 11:28 ` [PATCH 02/14] backports: add wait_event_killable_timeout backport support Luca Coelho
2018-09-20 11:28 ` [PATCH 03/14] backport: introduce match_string() for kernels < 4.6 Luca Coelho
2018-09-20 11:28 ` [PATCH 04/14] backport: add patch to ignore iwlwifi removal on < 3.14 kernels Luca Coelho
2018-09-20 11:28 ` [PATCH 05/14] backport: convert tree section names to ascii Luca Coelho
2018-09-20 11:28 ` [PATCH 06/14] backport: add rhashtable-types.h Luca Coelho
2018-09-20 11:28 ` [PATCH 07/14] backport: remove duplicate leds.h inclusion from backport-4.5.c Luca Coelho
2018-09-20 11:28 ` [PATCH 08/14] backport: prevent unused subclass variable warning in < 3.18 Luca Coelho
2018-09-20 11:28 ` [PATCH 09/14] backport: make ktime_get_boottime_seconds() non-inline Luca Coelho
2018-09-20 11:28 ` [PATCH 10/14] backport: update u64_stats_init() to a new version in kernels < 4.2 Luca Coelho
2018-09-20 11:28 ` [PATCH 11/14] backports: improve skb->xmit_more handling Luca Coelho
2018-09-20 11:28 ` [PATCH 12/14] backport: update lib-rhashtable.c Luca Coelho
2018-09-20 16:23   ` Luciano Coelho
2018-09-20 11:28 ` [PATCH 13/14] backport: convert int led activate op to void when needed Luca Coelho
2018-09-23 12:30   ` Hauke Mehrtens
2018-09-24  9:24     ` Luca Coelho [this message]
2018-09-20 11:28 ` [PATCH 14/14] backports: add __alloc_bucket_spinlocks() for < 4.19 Luca Coelho
2018-09-23 14:14 ` [PATCH 00/14] backport: updates for 4.19 Hauke Mehrtens
2018-09-24  9:26   ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=948ce87ddf7b135e98506a2f0f2d56d9ccb43228.camel@coelho.fi \
    --to=luca@coelho.fi \
    --cc=backports@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Backports Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/backports/0 backports/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 backports backports/ https://lore.kernel.org/backports \
		backports@vger.kernel.org
	public-inbox-index backports

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.backports


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git