backports.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Omer Efrat <omer.efrat@tandemg.com>
To: Hauke Mehrtens <hauke@hauke-m.de>,
	"backports@vger.kernel.org" <backports@vger.kernel.org>
Cc: "aspriel@gmail.com" <aspriel@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	John Crispin <john@phrozen.org>
Subject: Re: .coredump spatch
Date: Tue, 18 Sep 2018 06:28:07 +0000	[thread overview]
Message-ID: <VI1PR02MB3631D220BDE0C139F4369F769A1D0@VI1PR02MB3631.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <a1e69bd7-132b-124b-d36c-b9cae361a9ff@hauke-m.de>

On Tue, Sep 18, 2018, Hauke Mehrtens wrote:

> The device structure now has this .coredump member which is also used by
> some wireless drivers, see here for example:
> https://git.kernel.org/linus/8e072168f75ebce85b96cbcefea2b10ddbd5913f
>=20
> I tried to create a spatch for this, but I failed to match the driver
> member because it is embedded inside an other structure, it looks like
> this for example:
>=20
> static struct pci_driver brcmf_pciedrvr =3D {
> ....
>         .driver.coredump =3D brcmf_dev_coredump,
> };
>=20
> I would like to convert this to this:
>=20
> static struct pci_driver brcmf_pciedrvr =3D {
> ....
> #if LINUX_VERSION_IS_GEQ(4,16,0)
>         .driver.coredump =3D brcmf_dev_coredump,
> #endif
> };
>=20
> Hauke

I think you should have a look at 0075-ndo-stats-64.cocci for a good refere=
nce.

Omer.=
--
To unsubscribe from this list: send the line "unsubscribe backports" in

WARNING: multiple messages have this Message-ID (diff)
From: Omer Efrat <omer.efrat@tandemg.com>
To: Hauke Mehrtens <hauke@hauke-m.de>,
	"backports@vger.kernel.org" <backports@vger.kernel.org>
Cc: "aspriel@gmail.com" <aspriel@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	John Crispin <john@phrozen.org>
Subject: Re: .coredump spatch
Date: Tue, 18 Sep 2018 06:28:07 +0000	[thread overview]
Message-ID: <VI1PR02MB3631D220BDE0C139F4369F769A1D0@VI1PR02MB3631.eurprd02.prod.outlook.com> (raw)
Message-ID: <20180918062807.U3lcjd6WTda1JGhlORXhJxcCk-AVtbMz3z-FwkoCaPg@z> (raw)
In-Reply-To: <a1e69bd7-132b-124b-d36c-b9cae361a9ff@hauke-m.de>

On Tue, Sep 18, 2018, Hauke Mehrtens wrote:

> The device structure now has this .coredump member which is also used by
> some wireless drivers, see here for example:
> https://git.kernel.org/linus/8e072168f75ebce85b96cbcefea2b10ddbd5913f
>=20
> I tried to create a spatch for this, but I failed to match the driver
> member because it is embedded inside an other structure, it looks like
> this for example:
>=20
> static struct pci_driver brcmf_pciedrvr =3D {
> ....
>         .driver.coredump =3D brcmf_dev_coredump,
> };
>=20
> I would like to convert this to this:
>=20
> static struct pci_driver brcmf_pciedrvr =3D {
> ....
> #if LINUX_VERSION_IS_GEQ(4,16,0)
>         .driver.coredump =3D brcmf_dev_coredump,
> #endif
> };
>=20
> Hauke

I think you should have a look at 0075-ndo-stats-64.cocci for a good refere=
nce.

Omer.=

  reply	other threads:[~2018-09-18 11:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 21:39 .coredump spatch Hauke Mehrtens
2018-09-18  6:28 ` Omer Efrat [this message]
2018-09-18  6:28   ` Omer Efrat
2018-09-18 21:49   ` Hauke Mehrtens
2018-09-19  8:49 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR02MB3631D220BDE0C139F4369F769A1D0@VI1PR02MB3631.eurprd02.prod.outlook.com \
    --to=omer.efrat@tandemg.com \
    --cc=aspriel@gmail.com \
    --cc=backports@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=johannes@sipsolutions.net \
    --cc=john@phrozen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).