From: Michal Marek <mmarek@suse.com>
To: Christoph Hellwig <hch@lst.de>, "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Cristina Moraru <cristina.moraru09@gmail.com>,
"vegard.nossum@gmail.com" <vegard.nossum@gmail.com>,
Valentin Rothberg <valentinrothberg@gmail.com>,
Hannes Reinecke <hare@suse.de>, Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, teg@jklm.no, kay@vrfy.org,
rusty@rustcorp.com.au, akpm@linux-foundation.org,
backports@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"rafael.j.wysocki" <rafael.j.wysocki@intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Takashi Iwai <tiwai@suse.de>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Johannes Berg <johannes@sipsolutions.net>,
Hauke Mehrtens <hauke@hauke-m.de>,
Paul Bolle <pebolle@tiscali.nl>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Laurence Oberman <loberman@redhat.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Tejun Heo <tj@kernel.org>,
Jej B <James.Bottomley@hansenpartnership.com>,
Theodore Ts'o <tytso@mit.edu>,
danijons@student.chalmers.se, Andrzej Wasowski <wasowski@itu.dk>
Subject: Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute
Date: Thu, 25 Aug 2016 10:41:25 +0200 [thread overview]
Message-ID: <cc2c4d65-aa57-a04d-8e2a-75c13943b2b7@suse.com> (raw)
In-Reply-To: <20160825074313.GC18622@lst.de>
On 2016-08-25 09:43, Christoph Hellwig wrote:
> The idea seems useful, but I reallt don't like the 'reverse-engineering'
> approach.
>
> If we want to this properly from the ground up we should just split out
> our CONFIG_ SYMBOLS into
>
> MODULE_* - builds exactly one module (tristate, or maybe also as a built-in
> only one, then like a bool)
>
> CONFIG_* - just bool, MODULE_ may depend on it, too.
>
> The other nice thing is that we could probably fold most of the Makefiles
> into Kconfig using that methods as well, by listing the objectes required
> for a module, e.g.
>
> module NVME_TARGET
> tristate "NVMe Target support"
> depends on BLOCK
> depends on CONFIGFS_FS
> name nvmet
> objects core.o configfs.o admin-cmd.o io-cmd.o fabrics-cmd.o
> objects discovery.o
>
> module NVME_TARGET_LOOP
> tristate "NVMe loopback device support"
> depends on BLK_DEV_NVME
> depends on NVME_TARGET
> select NVME_FABRICS
> select SG_POOL
> name nvme-loop
> objects loop.o
It looks nice for the simple case, but as soon as you need something
non-standard, you will need to mix a kconfig generated and a manually
written Makefile snippet.
Michal
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2016-08-25 8:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1471462023-119645-1-git-send-email-cristina.moraru09@gmail.com>
2016-08-18 17:55 ` [RFC PATCH 0/5] Add CONFIG symbol as module attribute Luis R. Rodriguez
2016-08-19 9:07 ` Michal Marek
2016-08-22 19:48 ` Cristina-Gabriela Moraru
2016-08-23 21:32 ` Luis R. Rodriguez
2016-08-24 11:05 ` Michal Marek
2016-08-24 16:33 ` Luis R. Rodriguez
2016-08-24 17:31 ` Naveen Kumar
2016-08-22 19:35 ` Cristina-Gabriela Moraru
2016-08-23 19:17 ` Luis R. Rodriguez
2016-08-25 7:43 ` Christoph Hellwig
2016-08-25 8:00 ` Johannes Berg
2016-08-25 19:51 ` Luis R. Rodriguez
2016-08-25 8:41 ` Michal Marek [this message]
2016-08-25 20:19 ` Luis R. Rodriguez
2019-02-05 22:07 ` Luis Chamberlain
2019-06-26 22:21 ` Luis Chamberlain
2019-06-27 4:50 ` Christoph Hellwig
2019-06-28 18:40 ` Luis Chamberlain
2019-06-29 8:42 ` Greg Kroah-Hartman
2019-07-02 20:51 ` Luis Chamberlain
2019-07-03 7:40 ` Greg Kroah-Hartman
2019-07-03 16:50 ` Luis Chamberlain
2019-07-03 18:57 ` Greg Kroah-Hartman
2019-07-03 22:25 ` Luis Chamberlain
2019-07-11 23:07 ` Brendan Higgins
2019-07-11 23:22 ` Luis Chamberlain
2019-07-03 12:16 ` Enrico Weigelt, metux IT consult
2019-07-03 17:35 ` Luis Chamberlain
2019-07-03 19:31 ` Enrico Weigelt, metux IT consult
2019-07-03 22:42 ` Luis Chamberlain
2019-07-11 23:27 ` Brendan Higgins
2019-07-13 14:44 ` Enrico Weigelt, metux IT consult
[not found] ` <1471462023-119645-3-git-send-email-cristina.moraru09@gmail.com>
2016-08-18 18:10 ` [RFC PATCH 2/5] Add CONFIG symbol to module as compilation parameter Luis R. Rodriguez
2016-08-18 18:55 ` Luis R. Rodriguez
2016-08-20 15:11 ` Cristina-Gabriela Moraru
2016-08-23 19:07 ` Luis R. Rodriguez
[not found] ` <1471462023-119645-2-git-send-email-cristina.moraru09@gmail.com>
2016-08-18 18:22 ` [RFC PATCH 1/5] Add generation of Module.symb in streamline_config Luis R. Rodriguez
2016-08-18 18:32 ` Luis R. Rodriguez
[not found] ` <CAGZ2q2xi9Uy-ye387=mWhy_fOEJBC593Nos7fH027m-_ZdoOXA@mail.gmail.com>
2016-08-20 14:49 ` Cristina-Gabriela Moraru
2016-08-23 19:00 ` Luis R. Rodriguez
[not found] ` <1471462023-119645-4-git-send-email-cristina.moraru09@gmail.com>
2016-08-18 18:30 ` [RFC PATCH 3/5] Trigger Module.ksymb generation in Makefile Luis R. Rodriguez
[not found] ` <1471462023-119645-5-git-send-email-cristina.moraru09@gmail.com>
2016-08-18 18:59 ` [RFC PATCH 4/5] Set KCONFIG_KSYMB as value for kconfig_ksymb module attribute Luis R. Rodriguez
2016-08-20 15:16 ` Cristina-Gabriela Moraru
2016-08-23 19:10 ` Luis R. Rodriguez
[not found] ` <1471462023-119645-6-git-send-email-cristina.moraru09@gmail.com>
2016-08-18 19:02 ` [RFC PATCH 5/5] Add kconf_symb as kernel " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc2c4d65-aa57-a04d-8e2a-75c13943b2b7@suse.com \
--to=mmarek@suse.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=backports@vger.kernel.org \
--cc=cristina.moraru09@gmail.com \
--cc=danijons@student.chalmers.se \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hauke@hauke-m.de \
--cc=hch@lst.de \
--cc=johannes@sipsolutions.net \
--cc=jthumshirn@suse.de \
--cc=kay@vrfy.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=paul.gortmaker@windriver.com \
--cc=pebolle@tiscali.nl \
--cc=rafael.j.wysocki@intel.com \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
--cc=sathya.prakash@broadcom.com \
--cc=teg@jklm.no \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
--cc=valentinrothberg@gmail.com \
--cc=vegard.nossum@gmail.com \
--cc=wasowski@itu.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).