From: Juergen Gross <jgross@suse.com>
To: Daniel Kiper <daniel.kiper@oracle.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, andrew.cooper3@citrix.com,
cardoe@cardoe.com, pgnet.dev@gmail.com, ning.sun@intel.com,
julien.grall@arm.com, jbeulich@suse.com, qiaowei.ren@intel.com,
gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH v10 09/13] x86: change default load address from 1 MiB to 2 MiB
Date: Wed, 30 Nov 2016 15:03:07 +0100 [thread overview]
Message-ID: <baf80dac-5f8b-97d0-9716-99ce865d7ca2@suse.com> (raw)
In-Reply-To: <f51f3bbf-f19b-56d1-1900-5b6bfe8520b4@suse.com>
On 30/11/16 14:51, Juergen Gross wrote:
> On 30/11/16 14:04, Daniel Kiper wrote:
>> Subsequent patches introducing relocatable early boot code play with
>> page tables using 2 MiB huge pages. If load address is not aligned at
>> 2 MiB then code touching such page tables must have special cases for
>> start and end of Xen image memory region. So, let's make life easier
>> and move default load address from 1 MiB to 2 MiB. This way page table
>> code will be nice and easy. Hence, there is a chance that it will be
>> less error prone too... :-)))
>>
>> Additionally, drop first 2 MiB mapping from Xen image mapping.
>> It is no longer needed.
>>
>> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> v8 - suggestions/fixes:
>> - drop first 2 MiB mapping from Xen image mapping
>> (suggested by Jan Beulich),
>> - improve commit message.
>>
>> v7 - suggestions/fixes:
>> - minor cleanups
>> (suggested by Jan Beulich).
>> ---
>> xen/arch/x86/Makefile | 2 +-
>> xen/arch/x86/Rules.mk | 3 +++
>> xen/arch/x86/boot/head.S | 8 --------
>> xen/arch/x86/boot/x86_64.S | 5 +++--
>> xen/arch/x86/setup.c | 3 ++-
>> xen/arch/x86/xen.lds.S | 2 +-
>> 6 files changed, 10 insertions(+), 13 deletions(-)
>>
>> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
>> index e74fe62..d5d0651 100644
>> --- a/xen/arch/x86/Makefile
>> +++ b/xen/arch/x86/Makefile
>> @@ -90,7 +90,7 @@ all_symbols =
>> endif
>>
>> $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>> - ./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TARGET) 0x100000 \
>> + ./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TARGET) $(XEN_IMG_OFFSET) \
>> `$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . __2M_rwdata_end$$/0x\1/p'`
>
> This doesn't apply (somehow you managed to insert spaces into the patch
> file).
Sorry for the noise, somehow I managed to skip patch 4.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-30 14:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 13:04 [PATCH v10 00/13] x86: multiboot2 protocol support Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 01/13] x86: add " Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 02/13] efi: create efi_enabled() Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 03/13] x86: allow EFI reboot method neither on EFI platforms Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 04/13] x86: properly calculate xen ELF end of image address Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 05/13] efi: build xen.gz with EFI code Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 06/13] efi: create new early memory allocator Daniel Kiper
2016-12-01 13:13 ` Jan Beulich
2016-12-01 15:41 ` Daniel Kiper
2016-12-01 16:08 ` Jan Beulich
2016-12-01 16:19 ` Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 07/13] x86: add multiboot2 protocol support for EFI platforms Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 08/13] x86/boot: implement early command line parser in C Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 09/13] x86: change default load address from 1 MiB to 2 MiB Daniel Kiper
2016-11-30 13:51 ` Juergen Gross
2016-11-30 14:03 ` Juergen Gross [this message]
2016-11-30 13:04 ` [PATCH v10 10/13] x86/setup: use XEN_IMG_OFFSET instead of Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 11/13] x86: make Xen early boot code relocatable Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 12/13] x86/boot: rename sym_phys() to sym_offs() Daniel Kiper
2016-11-30 13:04 ` [PATCH v10 13/13] x86: add multiboot2 protocol support for relocatable images Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf80dac-5f8b-97d0-9716-99ce865d7ca2@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=daniel.kiper@oracle.com \
--cc=fu.wei@linaro.org \
--cc=gang.wei@intel.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=ning.sun@intel.com \
--cc=pgnet.dev@gmail.com \
--cc=qiaowei.ren@intel.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.