b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v3 2/2] batman-adv: fix splat on disabling an interface
Date: Fri, 21 Oct 2016 14:49:42 +0200	[thread overview]
Message-ID: <105532917.i5QgYZh4kb@bentobox> (raw)
In-Reply-To: <20161005234308.29871-3-linus.luessing@c0d3.blue>

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

On Donnerstag, 6. Oktober 2016 01:43:08 CEST Linus Lüssing wrote:
> As long as there is still a reference for a hard interface held, there
> might still be a forwarding packet relying on its attributes.
> 
> Therefore avoid setting hard_iface->soft_iface to NULL when disabling a
> hard interface.
> 
> This fixes the following, potential splat:
> 
[...]
> 
> What happened here is, that there was still a forw_packet (here: a
> BATMAN IV OGM) in the queue of eth3 with the forw_packet->if_incoming
> set to eth1 and the forw_packet->if_outgoing set to eth3.
> 
> When eth3 is to be deactivated and removed, then this thread waits for
> the forw_packet queued on eth3 to finish. Because eth1 was deactivated
> and removed earlier and by that had forw_packet->if_incoming->soft_iface,
> set to NULL, the splat when trying to send/flush the OGM on eth3
> occures.
> 
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> 
> ---
> 
> Changes in v3:
> * none
> 
> Changes in v2:
> * none, new patch
> ---
>  net/batman-adv/hard-interface.c | 1 -
>  1 file changed, 1 deletion(-)

Applied in bac7733d06fac28ce68a79bcdf88b2b265600cf2 [1]

Kind regards,
	Sven

[1] https://git.open-mesh.org/batman-adv.git/commit/bac7733d06fac28ce68a79bcdf88b2b265600cf2

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

      reply	other threads:[~2016-10-21 12:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05 23:43 [B.A.T.M.A.N.] [PATCH v3 0/2] batman-adv: hard interface removal fixes Linus Lüssing
2016-10-05 23:43 ` [B.A.T.M.A.N.] [PATCH v3 1/2] batman-adv: fix race conditions on interface removal Linus Lüssing
2016-10-21 12:30   ` Sven Eckelmann
2016-10-29  2:46     ` Linus Lüssing
2016-10-29  6:55       ` Sven Eckelmann
2016-10-31  7:22         ` Linus Lüssing
2016-10-31  8:09           ` Sven Eckelmann
2016-10-31  9:57             ` Linus Lüssing
2016-10-05 23:43 ` [B.A.T.M.A.N.] [PATCH v3 2/2] batman-adv: fix splat on disabling an interface Linus Lüssing
2016-10-21 12:49   ` Sven Eckelmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=105532917.i5QgYZh4kb@bentobox \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).