From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@open-mesh.net
Cc: Dan Carpenter <error27@gmail.com>
Subject: [B.A.T.M.A.N.] [PATCH] batman-adv: return -EFAULT on copy_to_user errors
Date: Thu, 3 Jun 2010 13:33:27 +0200 [thread overview]
Message-ID: <1275564807-8725-1-git-send-email-sven.eckelmann@gmx.de> (raw)
In-Reply-To: <20100603100437.GS5483@bicker>
From: Dan Carpenter <error27@gmail.com>
copy_to_user() returns the number of bites remaining but we want to
return a negative error code here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
[sven.eckelmann@gmx.de: Move change from device.c to icmp_socket.c]
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
---
This patch is already applied in maint and must be applied in master.
batman-adv-kernelland/icmp_socket.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/batman-adv-kernelland/icmp_socket.c b/batman-adv-kernelland/icmp_socket.c
index bad87fd..08cca22 100644
--- a/batman-adv-kernelland/icmp_socket.c
+++ b/batman-adv-kernelland/icmp_socket.c
@@ -148,7 +148,7 @@ static ssize_t bat_socket_read(struct file *file, char __user *buf,
kfree(socket_packet);
if (error)
- return error;
+ return -EFAULT;
return packet_len;
}
--
1.7.1
next parent reply other threads:[~2010-06-03 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100603100437.GS5483@bicker>
2010-06-03 11:33 ` Sven Eckelmann [this message]
2010-06-05 17:47 ` [B.A.T.M.A.N.] [PATCH] batman-adv: return -EFAULT on copy_to_user errors Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275564807-8725-1-git-send-email-sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=b.a.t.m.a.n@open-mesh.net \
--cc=error27@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).