b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	David Miller <davem@davemloft.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars
Date: Tue, 20 Dec 2011 20:56:20 +0000	[thread overview]
Message-ID: <1324414580.2818.31.camel@bwh-desktop> (raw)
In-Reply-To: <201112210315.02171.lindner_marek@yahoo.de>

On Wed, 2011-12-21 at 03:15 +0800, Marek Lindner wrote:
> On Wednesday, December 21, 2011 03:02:09 David Miller wrote:
> > From: Marek Lindner <lindner_marek@yahoo.de>
> > Date: Wed, 21 Dec 2011 02:59:41 +0800
> > 
> > > On Wednesday, December 21, 2011 02:32:30 David Miller wrote:
> > >> From: Marek Lindner <lindner_marek@yahoo.de>
> > >> Date: Tue, 20 Dec 2011 18:38:24 +0800
> > >> 
> > >> > The long line was introduced with b26e478f8f.
> > >> > 
> > >> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> > >> 
> > >> I'm not applying this.
> > >> 
> > >> I tell people to make sure arguments line up correctly to the
> > >> openning parenthesis on the previous line, and that is what is
> > >> happening here.
> > > 
> > > I am not against lining up the arguments but what about checkpatch ? Are
> > > we going to ignore the complaints or is this line limit about to be
> > > changed ?
> > 
> > Refactor the code so that both constraints can be satisfied.
> > 
> > Is this so hard to understand?
> 
> Well, my crystal ball did not unveil that a checkpatch complaint you silently 
> introduced would mean somebody else has to refactor the code. Guess I have to 
> get a replacement unit.

No-one has to refactor the code.  I think David's point is that he's
more concerned about proper alignment than having every line under 80
characters.  If you want to satisfy the latter constraint, you still
have to satisfy the former.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


      reply	other threads:[~2011-12-20 20:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20 10:38 [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars Marek Lindner
2011-12-20 18:32 ` David Miller
2011-12-20 18:59   ` Marek Lindner
2011-12-20 19:02     ` David Miller
2011-12-20 19:15       ` Marek Lindner
2011-12-20 20:56         ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324414580.2818.31.camel@bwh-desktop \
    --to=bhutchings@solarflare.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=lindner_marek@yahoo.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).