From: Marek Lindner <lindner_marek@yahoo.de>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Marek Lindner <lindner_marek@yahoo.de>
Subject: [B.A.T.M.A.N.] [PATCH 4/8] batman-adv: set TT_CLIENT_NEW flag before invoking hash_add()
Date: Tue, 28 Feb 2012 19:32:24 +0800 [thread overview]
Message-ID: <1330428748-23137-5-git-send-email-lindner_marek@yahoo.de> (raw)
In-Reply-To: <1330428748-23137-1-git-send-email-lindner_marek@yahoo.de>
From: Antonio Quartulli <ordex@autistici.org>
In case of a new tt_local_entry, the TT_CLIENT_NEW flag has to be set before
adding such entry to the hash table. Otherwise, it opens a race condition
in which the entry can be found but the flag has not been set.
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
net/batman-adv/translation-table.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index 4dc5af3..9be9c41 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -210,6 +210,11 @@ void tt_local_add(struct net_device *soft_iface, const uint8_t *addr,
if (compare_eth(addr, soft_iface->dev_addr))
tt_local_entry->common.flags |= TT_CLIENT_NOPURGE;
+ /* The local entry has to be marked as NEW to avoid to send it in
+ * a full table response going out before the next ttvn increment
+ * (consistency check) */
+ tt_local_entry->common.flags |= TT_CLIENT_NEW;
+
hash_added = hash_add(bat_priv->tt_local_hash, compare_tt, choose_orig,
&tt_local_entry->common,
&tt_local_entry->common.hash_entry);
@@ -222,11 +227,6 @@ void tt_local_add(struct net_device *soft_iface, const uint8_t *addr,
tt_local_event(bat_priv, addr, tt_local_entry->common.flags);
- /* The local entry has to be marked as NEW to avoid to send it in
- * a full table response going out before the next ttvn increment
- * (consistency check) */
- tt_local_entry->common.flags |= TT_CLIENT_NEW;
-
/* remove address from global hash if present */
tt_global_entry = tt_global_hash_find(bat_priv, addr);
--
1.7.9
next prev parent reply other threads:[~2012-02-28 11:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 11:32 [B.A.T.M.A.N.] pull request: batman-adv 2012-02-28 Marek Lindner
2012-02-28 11:32 ` [B.A.T.M.A.N.] [PATCH 1/8] batman-adv: convert time_after instances to has_timed_out Marek Lindner
2012-02-28 11:32 ` [B.A.T.M.A.N.] [PATCH 2/8] batman-adv: refactor tt_global_del() to avoid misalignment Marek Lindner
2012-02-28 11:32 ` [B.A.T.M.A.N.] [PATCH 3/8] batman-adv: Update copyright years Marek Lindner
2012-02-28 11:32 ` Marek Lindner [this message]
2012-02-28 11:32 ` [B.A.T.M.A.N.] [PATCH 5/8] batman-adv: code refactoring - move debug print into tt_local_set_pending Marek Lindner
2012-02-28 11:32 ` [B.A.T.M.A.N.] [PATCH 6/8] batman-adv: TT_CLIENT_PENDING is never set in struct tt_global_entry Marek Lindner
2012-02-28 11:38 ` Marek Lindner
2012-02-28 11:39 ` [B.A.T.M.A.N.] [PATCH 7/8] batman-adv: Start new development cycle Marek Lindner
2012-02-28 11:39 ` [B.A.T.M.A.N.] [PATCH 8/8] batman-adv: Fix indentation of multiline statements Marek Lindner
2012-02-28 20:09 ` [B.A.T.M.A.N.] pull request: batman-adv 2012-02-28 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330428748-23137-5-git-send-email-lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).