b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Quartulli <ordex@autistici.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: drop useless argument for arp_change_timeout()
Date: Tue, 17 Apr 2012 12:24:52 +0200	[thread overview]
Message-ID: <1334658294-2413-1-git-send-email-ordex@autistici.org> (raw)

The net_device structure already has a "name" field therefore we don't need to
pass the name by using another parameter.

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
 distributed-arp-table.c |    4 ++--
 distributed-arp-table.h |    2 +-
 soft-interface.c        |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/distributed-arp-table.c b/distributed-arp-table.c
index b43bece..5386af0 100644
--- a/distributed-arp-table.c
+++ b/distributed-arp-table.c
@@ -562,12 +562,12 @@ bool dat_drop_broadcast_packet(struct bat_priv *bat_priv,
 	return false;
 }
 
-void arp_change_timeout(struct net_device *soft_iface, const char *name)
+void arp_change_timeout(struct net_device *soft_iface)
 {
 	struct in_device *in_dev = in_dev_get(soft_iface);
 	if (!in_dev) {
 		pr_err("Unable to set ARP parameters for the batman interface '%s'\n",
-		       name);
+		       soft_iface->name);
 		return;
 	}
 
diff --git a/distributed-arp-table.h b/distributed-arp-table.h
index 26b98c0..c16aa1b 100644
--- a/distributed-arp-table.h
+++ b/distributed-arp-table.h
@@ -49,7 +49,7 @@ bool dat_snoop_incoming_arp_reply(struct bat_priv *bat_priv,
 				  struct sk_buff *skb, int hdr_size);
 bool dat_drop_broadcast_packet(struct bat_priv *bat_priv,
 			       struct forw_packet *forw_packet);
-void arp_change_timeout(struct net_device *soft_iface, const char *name);
+void arp_change_timeout(struct net_device *soft_iface);
 
 /* hash function to choose an entry in a hash table of given size */
 /* hash algorithm from http://en.wikipedia.org/wiki/Hash_table */
diff --git a/soft-interface.c b/soft-interface.c
index b56dafd..de0ceb2 100644
--- a/soft-interface.c
+++ b/soft-interface.c
@@ -381,7 +381,7 @@ struct net_device *softif_create(const char *name)
 		goto free_soft_iface;
 	}
 
-	arp_change_timeout(soft_iface, name);
+	arp_change_timeout(soft_iface);
 
 	bat_priv = netdev_priv(soft_iface);
 
-- 
1.7.9.4


             reply	other threads:[~2012-04-17 10:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17 10:24 Antonio Quartulli [this message]
2012-04-17 10:24 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: introduce a boolean switch to enable/disable DAT Antonio Quartulli
2012-04-17 10:33   ` Marek Lindner
2012-04-17 10:35   ` Marek Lindner
2012-04-17 10:24 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: use static inline functions instead of bla(...) Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334658294-2413-1-git-send-email-ordex@autistici.org \
    --to=ordex@autistici.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).