From: Joe Perches <joe@perches.com>
To: Marek Lindner <mareklindner@neomailbox.ch>
Cc: "b.a.t.m.a.n" <b.a.t.m.a.n@lists.open-mesh.org>,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [B.A.T.M.A.N.] checkpatch: CHECK: No space is necessary after a cast
Date: Thu, 19 Feb 2015 11:55:41 -0800 [thread overview]
Message-ID: <1424375741.18211.4.camel@perches.com> (raw)
In-Reply-To: <2621923.3aVJ40SYcy@voltaire>
On Thu, 2015-02-19 at 13:35 +0800, Marek Lindner wrote:
> Hi Joe,
Hi Marek
> we have come across a checkpatch false-positive:
[]
> BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
> CHECK: No space is necessary after a cast
> #440: FILE: main.c:440:
> + BUILD_BUG_ON(sizeof(struct batadv_bla_claim_dst) != 6);
[]
> Can you make a suggestion / patch for checkpatch to better handle this case ?
The "sizeof" test in the current script doesn't work.
I believe the patch below works with no false positives
but <shrug> it's perl regexes against odd coding styles
and weird macros, who knows for sure...
I did run it against drivers/, net/ and include/
Give this a try:
---
scripts/checkpatch.pl | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d124359..2f5bb27 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2552,9 +2552,15 @@ sub process {
}
}
- if ($line =~ /^\+.*(\w+\s*)?\(\s*$Type\s*\)[ \t]+(?!$Assignment|$Arithmetic|[,;:\?\(\{\}\[\<\>]|&&|\|\||\\$)/ &&
- (!defined($1) || $1 !~ /sizeof\s*/)) {
- if (CHK("SPACING",
+# check for space after cast like "(int) foo" or "(struct foo) bar"
+# avoid checking a few false positives:
+# "sizeof(<type>)" or "__alignof__(<type>)"
+# function pointer declarations like "(*foo)(int) = bar;"
+# structure definitions like "(struct foo) { 0 };"
+# multiline macros that define functions
+ if ($line =~ /^\+(.*)\(\s*$Type\s*\)([ \t]++)((?![={]|\\$))/ &&
+ (!defined($1) || $1 !~ /\b(?:sizeof|__alignof__)\s*$/)) {
+ if (CHK("SPACING",
"No space is necessary after a cast\n" . $herecurr) &&
$fix) {
$fixed[$fixlinenr] =~
next prev parent reply other threads:[~2015-02-19 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 5:35 [B.A.T.M.A.N.] checkpatch: CHECK: No space is necessary after a cast Marek Lindner
2015-02-19 19:55 ` Joe Perches [this message]
2015-02-20 11:56 ` Marek Lindner
2015-02-20 19:52 ` [B.A.T.M.A.N.] [PATCH] checkpatch: Improve "no space is necessary after a cast" test Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424375741.18211.4.camel@perches.com \
--to=joe@perches.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).