From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <mareklindner@neomailbox.ch>
Subject: [B.A.T.M.A.N.] [PATCH] batman-adv: protect tt_local_entry from concurrent delete events
Date: Wed, 17 Jun 2015 20:09:55 +0800 [thread overview]
Message-ID: <1434542995-22376-1-git-send-email-mareklindner@neomailbox.ch> (raw)
The tt_local_entry deletion performed batadv_tt_local_remove() was neither
protecting against simultaneous deletes nor checking whether the element
was still part of the list before calling hlist_del_rcu().
Replacing the hlist_del_rcu() with batadv_hash_remove() provides adequate
protection via hash spinlocks as well as a is-element-still-in-hash check.
Reported-by: alfonsname@web.de
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
---
translation-table.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/translation-table.c b/translation-table.c
index e95a424..4afeeb5 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -1042,7 +1042,8 @@ uint16_t batadv_tt_local_remove(struct batadv_priv *bat_priv,
* immediately purge it
*/
batadv_tt_local_event(bat_priv, tt_local_entry, BATADV_TT_CLIENT_DEL);
- hlist_del_rcu(&tt_local_entry->common.hash_entry);
+ batadv_hash_remove(bat_priv->tt.local_hash, batadv_compare_tt,
+ batadv_choose_tt, &tt_local_entry->common);
batadv_tt_local_entry_free_ref(tt_local_entry);
/* decrease the reference held for this vlan */
--
2.1.4
next reply other threads:[~2015-06-17 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 12:09 Marek Lindner [this message]
2015-06-17 12:36 ` [B.A.T.M.A.N.] [PATCH] batman-adv: protect tt_local_entry from concurrent delete events Antonio Quartulli
2015-06-17 15:24 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434542995-22376-1-git-send-email-mareklindner@neomailbox.ch \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).