b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: davem@davemloft.net
Cc: Ruben Wisniewsi <ruben@vfn-nrw.de>,
	Marek Lindner <mareklindner@neomailbox.ch>,
	netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Antonio Quartulli <antonio@meshcoding.com>
Subject: [B.A.T.M.A.N.] [PATCH 02/10] batman-adv: Avoid u32 overflow during gateway select
Date: Tue, 11 Aug 2015 18:35:40 +0200	[thread overview]
Message-ID: <1439310948-32426-3-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1439310948-32426-1-git-send-email-antonio@meshcoding.com>

From: Ruben Wisniewski <ruben@freifunk-nrw.de>

The gateway selection based on fast connections is using a single value
calculated from the average tq (0-255) and the download bandwidth (in
100Kibit). The formula for the first step (tq ** 2 * 10000 * bandwidth)
tends to overflow a u32 with low bandwidth settings like 50 [100KiBit]
and a tq value of over 92.

Changing this to a 64 bit unsigned integer allows to support a
bandwidth_down with up to ~2.8e10 [100KiBit] and a perfect tq of 255. This
is ~6.6 times higher than the maximum possible value of the gateway
announcement TVLV.

This problem only affects the non-default gw_sel_class 1.

Signed-off-by: Ruben Wisniewsi <ruben@vfn-nrw.de>
[sven@narfation.org: rewritten commit message]
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 net/batman-adv/gateway_client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index e1e1f31..4ac24d8 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -153,7 +153,7 @@ batadv_gw_get_best_gw_node(struct batadv_priv *bat_priv)
 	struct batadv_neigh_node *router;
 	struct batadv_neigh_ifinfo *router_ifinfo;
 	struct batadv_gw_node *gw_node, *curr_gw = NULL;
-	uint32_t max_gw_factor = 0, tmp_gw_factor = 0;
+	uint64_t max_gw_factor = 0, tmp_gw_factor = 0;
 	uint8_t max_tq = 0;
 	uint8_t tq_avg;
 	struct batadv_orig_node *orig_node;
-- 
2.5.0


  parent reply	other threads:[~2015-08-11 16:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 16:35 [B.A.T.M.A.N.] pull request: batman-adv 20150811 Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 01/10] batman-adv: Replace gw_reselect divisor with simple shift Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli [this message]
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic Antonio Quartulli
2015-08-11 19:36   ` Sergei Shtylyov
2015-08-14 20:49     ` Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: Make NC " Antonio Quartulli
2015-08-11 19:38   ` Sergei Shtylyov
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 05/10] batman-adv: Make TT " Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 06/10] batman-adv: Make MCAST " Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 07/10] batman-adv: Fix potential synchronization issues in mcast tvlv handler Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 08/10] batman-adv: protect tt request from double deletion Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 09/10] batman-adv: remove broadcast packets scheduled for purged outgoing if Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 10/10] batman-adv: Fix potentially broken skb network header access Antonio Quartulli
2015-08-14 20:57 [B.A.T.M.A.N.] pull request: batman-adv 20150814 Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 02/10] batman-adv: Avoid u32 overflow during gateway select Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439310948-32426-3-git-send-email-antonio@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=mareklindner@neomailbox.ch \
    --cc=netdev@vger.kernel.org \
    --cc=ruben@vfn-nrw.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).