b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Antonio Quartulli <antonio@meshcoding.com>,
	Marek Lindner <mareklindner@neomailbox.ch>
Subject: [B.A.T.M.A.N.] [PATCH 10/10] batman-adv: Fix potentially broken skb network header access
Date: Fri, 14 Aug 2015 22:57:14 +0200	[thread overview]
Message-ID: <1439585834-26564-11-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1439585834-26564-1-git-send-email-antonio@meshcoding.com>

From: Linus Lüssing <linus.luessing@c0d3.blue>

The two commits noted below added calls to ip_hdr() and ipv6_hdr(). They
need a correctly set skb network header.

Unfortunately we cannot rely on the device drivers to set it for us.
Therefore setting it in the beginning of the according ndo_start_xmit
handler.

Fixes: 1d8ab8d3c176 ("batman-adv: Modified forwarding behaviour for multicast packets")
Fixes: ab49886e3da7 ("batman-adv: Add IPv4 link-local/IPv6-ll-all-nodes multicast support")
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 net/batman-adv/soft-interface.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index c002961..926292d 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -202,6 +202,7 @@ static int batadv_interface_tx(struct sk_buff *skb,
 	int gw_mode;
 	enum batadv_forw_mode forw_mode;
 	struct batadv_orig_node *mcast_single_orig = NULL;
+	int network_offset = ETH_HLEN;
 
 	if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE)
 		goto dropped;
@@ -214,14 +215,18 @@ static int batadv_interface_tx(struct sk_buff *skb,
 	case ETH_P_8021Q:
 		vhdr = vlan_eth_hdr(skb);
 
-		if (vhdr->h_vlan_encapsulated_proto != ethertype)
+		if (vhdr->h_vlan_encapsulated_proto != ethertype) {
+			network_offset += VLAN_HLEN;
 			break;
+		}
 
 		/* fall through */
 	case ETH_P_BATMAN:
 		goto dropped;
 	}
 
+	skb_set_network_header(skb, network_offset);
+
 	if (batadv_bla_tx(bat_priv, skb, vid))
 		goto dropped;
 
-- 
2.5.0


  parent reply	other threads:[~2015-08-14 20:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 20:57 [B.A.T.M.A.N.] pull request: batman-adv 20150814 Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 01/10] batman-adv: Replace gw_reselect divisor with simple shift Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 02/10] batman-adv: Avoid u32 overflow during gateway select Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: Make NC " Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 05/10] batman-adv: Make TT " Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 06/10] batman-adv: Make MCAST " Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 07/10] batman-adv: Fix potential synchronization issues in mcast tvlv handler Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 08/10] batman-adv: protect tt request from double deletion Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 09/10] batman-adv: remove broadcast packets scheduled for purged outgoing if Antonio Quartulli
2015-08-14 20:57 ` Antonio Quartulli [this message]
2015-08-17 21:32 ` [B.A.T.M.A.N.] pull request: batman-adv 20150814 David Miller
  -- strict thread matches above, loose matches on Subject: below --
2015-08-11 16:35 [B.A.T.M.A.N.] pull request: batman-adv 20150811 Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 10/10] batman-adv: Fix potentially broken skb network header access Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439585834-26564-11-git-send-email-antonio@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=mareklindner@neomailbox.ch \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).