From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH v3 2/6] batman-adv: NETIF_F_NETNS_LOCAL feature to prevent netns moves
Date: Sun, 13 Mar 2016 19:50:30 +0100 [thread overview]
Message-ID: <1457895034-13823-2-git-send-email-sven@narfation.org> (raw)
In-Reply-To: <3465881.llCNFeNLl4@sven-edge>
From: Andrew Lunn <andrew@lunn.ch>
The batX soft interface should not be moved between network name
spaces. This is similar to bridges, bonds, tunnels, which are not
allowed to move between network namespaces.
Suggested-by: Daniel Ehlers <danielehlers@mindeye.net>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Antonio Quartulli <a@unstable.cc>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
net/batman-adv/soft-interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index 7679f3a..f4aa60a 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -955,7 +955,7 @@ static void batadv_softif_init_early(struct net_device *dev)
dev->netdev_ops = &batadv_netdev_ops;
dev->destructor = batadv_softif_free;
- dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
+ dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_NETNS_LOCAL;
dev->priv_flags |= IFF_NO_QUEUE;
/* can't call min_mtu, because the needed variables
--
2.7.0
next prev parent reply other threads:[~2016-03-13 18:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 18:48 [B.A.T.M.A.N.] [PATCH v3 0/6] batman-adv: Add network name space support Sven Eckelmann
2016-03-13 18:50 ` [B.A.T.M.A.N.] [PATCH v3 1/6] batman-adv: Introduce compat-patches support Sven Eckelmann
2016-03-13 18:50 ` Sven Eckelmann [this message]
2016-03-13 18:50 ` [B.A.T.M.A.N.] [PATCH v3 3/6] batman-adv: Create batman soft interfaces within correct netns Sven Eckelmann
2016-03-13 18:50 ` [B.A.T.M.A.N.] [PATCH v3 4/6] batman-adv: Handle parent interfaces in a different netns Sven Eckelmann
2016-03-13 18:50 ` [B.A.T.M.A.N.] [PATCH v3 5/6] batman-adv: Add compatibility header for linux/ns_common.h Sven Eckelmann
2016-03-13 18:50 ` [B.A.T.M.A.N.] [PATCH v3 6/6] batman-adv: debugfs: Add netns support Sven Eckelmann
2016-03-14 10:57 ` Sven Eckelmann
2016-03-14 14:06 ` Andrew Lunn
2016-03-14 15:56 ` Sven Eckelmann
2016-03-14 19:20 ` Andrew Lunn
2016-03-13 22:40 ` [B.A.T.M.A.N.] [PATCH v3 0/6] batman-adv: Add network name space support Andrew Lunn
2016-03-14 7:17 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457895034-13823-2-git-send-email-sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).