b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Antonio Quartulli <a@unstable.cc>,
	Marek Lindner <mareklindner@neomailbox.ch>
Subject: [B.A.T.M.A.N.] [PATCH 02/17] batman-adv: statically print gateway table header
Date: Fri,  1 Jul 2016 15:08:54 +0200	[thread overview]
Message-ID: <1467378549-9646-3-git-send-email-sw@simonwunderlich.de> (raw)
In-Reply-To: <1467378549-9646-1-git-send-email-sw@simonwunderlich.de>

From: Antonio Quartulli <a@unstable.cc>

To make it easier to search through the code it is better to print static
strings directly instead of using format strings printing constants.

This was addressed in a previous patch, but the Gateway table header
was not updated accordingly.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
 net/batman-adv/gateway_client.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index 5839c56..b9d72e9 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -638,8 +638,7 @@ int batadv_gw_client_seq_print_text(struct seq_file *seq, void *offset)
 		goto out;
 
 	seq_printf(seq,
-		   "      %-12s (%s/%i) %17s [%10s]: advertised uplink bandwidth ... [B.A.T.M.A.N. adv %s, MainIF/MAC: %s/%pM (%s)]\n",
-		   "Gateway", "#", BATADV_TQ_MAX_VALUE, "Nexthop", "outgoingIF",
+		   "      Gateway      (#/255)           Nexthop [outgoingIF]: advertised uplink bandwidth ... [B.A.T.M.A.N. adv %s, MainIF/MAC: %s/%pM (%s)]\n",
 		   BATADV_SOURCE_VERSION, primary_if->net_dev->name,
 		   primary_if->net_dev->dev_addr, net_dev->name);
 
-- 
2.8.1


  parent reply	other threads:[~2016-07-01 13:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01 13:08 [B.A.T.M.A.N.] pull request for net-next: batman-adv 2016-07-01 Simon Wunderlich
2016-07-01 13:08 ` [B.A.T.M.A.N.] [PATCH 01/17] batman-adv: Start new development cycle Simon Wunderlich
2016-07-01 13:08 ` Simon Wunderlich [this message]
2016-07-01 17:19   ` [B.A.T.M.A.N.] [PATCH 02/17] batman-adv: statically print gateway table header Joe Perches
2016-07-01 13:08 ` [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: remove unused vid local variable in tt seq print Simon Wunderlich
2016-07-01 13:08 ` [B.A.T.M.A.N.] [PATCH 04/17] batman-adv: document sysfs files in alphabetical order Simon Wunderlich
2016-07-01 13:08 ` [B.A.T.M.A.N.] [PATCH 05/17] batman-adv: update elp interval documentation Simon Wunderlich
2016-07-01 13:08 ` [B.A.T.M.A.N.] [PATCH 06/17] batman-adv: refactor batadv_neigh_node_* functions to follow common style Simon Wunderlich
2016-07-01 13:08 ` [B.A.T.M.A.N.] [PATCH 07/17] batman-adv: remove unused callback from batadv_algo_ops struct Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 08/17] batman-adv: remove ogm_emit and ogm_schedule API calls Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 09/17] batman-adv: remove useless inline attribute for sysfs helper function Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 10/17] batman-adv: move GW mode and selection class to private data structure Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 11/17] batman-adv: init ELP tweaking options only once Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 12/17] batman-adv: Set skb priority in fragments Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 13/17] batman-adv: Include frame priority in fragment header Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 14/17] batman-adv: Always flood IGMP/MLD reports Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 15/17] batman-adv: Add multicast optimization support for bridged setups Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 16/17] batman-adv: Adding logging of mcast flag changes Simon Wunderlich
2016-07-01 13:09 ` [B.A.T.M.A.N.] [PATCH 17/17] batman-adv: Add debugfs table for mcast flags Simon Wunderlich
2016-07-01 21:05 ` [B.A.T.M.A.N.] pull request for net-next: batman-adv 2016-07-01 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467378549-9646-3-git-send-email-sw@simonwunderlich.de \
    --to=sw@simonwunderlich.de \
    --cc=a@unstable.cc \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=mareklindner@neomailbox.ch \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).