From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/1] batman-adv: Always flood IGMP/MLD reports
Date: Fri, 26 Jun 2015 14:43:38 +0200 [thread overview]
Message-ID: <1546214.ho8OvXx5F8@prime> (raw)
In-Reply-To: <1434893777-17618-2-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]
On Sunday 21 June 2015 15:36:17 Linus Lüssing wrote:
> With this patch IGMP or MLD reports are always flooded. This is
> necessary for the upcoming bridge integration:
>
> An IGMPv2/MLDv1 querier does not actively join the multicast group the
> reports are sent to. Because of this, this would lead to snooping
> bridges/switches not being able to learn of multicast listeners in the
> mesh and wrongly shutting down ports for multicast traffic to the mesh,
> leading to packet loss.
>
> This patch increments the multicast tvlv version number to 2.
>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
After discussing with Linus, I agree that we should use the more simple
approach and focus our optimizations effort on actual multicast traffic instead
of the reports. I think this approach is much more simpler and easier to debug
- since the multicast subject itself is complex enough on its own.
The patch is pretty much straight forward, most of the code is actually
adopted from the Linux kernel. Therefore:
Acked-by: Simon Wunderlich <sw@simonwunderlich.de>
Thank you!
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2015-06-26 12:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 13:36 [B.A.T.M.A.N.] [PATCH 0/1] batman-adv: Always flood IGMP/MLD reports Linus Lüssing
2015-06-21 13:36 ` [B.A.T.M.A.N.] [PATCH 1/1] " Linus Lüssing
2015-06-26 12:43 ` Simon Wunderlich [this message]
2015-06-28 1:37 ` Marek Lindner
2015-06-28 3:59 ` Linus Lüssing
2015-06-28 13:21 ` Marek Lindner
2015-06-29 2:52 ` Linus Lüssing
2015-06-29 4:42 ` Linus Lüssing
2015-06-22 17:55 ` [B.A.T.M.A.N.] [PATCH 0/1] " Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546214.ho8OvXx5F8@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).