From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: Fix broadcast/ogm queue limit on a removed interface
Date: Thu, 10 Mar 2016 18:44:39 +0100 [thread overview]
Message-ID: <1676205.nXJgt3zli3@bentobox> (raw)
In-Reply-To: <1366236516-14512-1-git-send-email-linus.luessing@web.de>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
On Thursday 18 April 2013 00:08:36 Linus Lüssing wrote:
> When removing a single interface while a broadcast or ogm packet is
> still pending then we will free the forward packet without releasing the
> queue slots again.
>
> This patch is supposed to fix this issue.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
> ---
You are talking a batman-adv interface when it contains multiple slave
interfaces, right? So batadv_purge_outstanding_packets would be called in
batadv_hardif_disable_interface and not in batadv_mesh_free (which is only
done when the batX interface will be removed).
This at least sounds legit and I cannot find where else this imbalance would
be fixed.
Acked-by: Sven Eckelmann <sven@narfation.org>
Kind regards,
Sven
PS: This patch only requires the path change from / to /net/batman-adv/ to
apply via git-am
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-03-10 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 21:54 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix broadcast queue limit on a removed interface Linus Lüssing
2013-04-17 21:54 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Refactor forward packet creation/destruction Linus Lüssing
2016-03-10 17:08 ` Sven Eckelmann
2016-04-09 16:23 ` Sven Eckelmann
2013-04-17 22:08 ` [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: Fix broadcast/ogm queue limit on a removed interface Linus Lüssing
2016-03-10 17:44 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1676205.nXJgt3zli3@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).