From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: fix counter for multicast supporting nodes
Date: Sun, 16 Nov 2014 16:53:57 +0800 [thread overview]
Message-ID: <1676843.nBZ6j67u22@diderot> (raw)
In-Reply-To: <1414644048-5792-2-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On Thursday 30 October 2014 05:40:46 Linus Lüssing wrote:
> A miscounting of nodes having multicast optimizations enabled can lead
> to multicast packet loss in the following scenario:
>
> If the first OGM a node receives from another one has no multicast
> optimizations support (no multicast tvlv) then we are missing to
> increase the counter. This potentially leads to the wrong assumption
> that we could safely use multicast optimizations.
>
> Fixings this by increasing the counter if the initial OGM has the
> multicast TVLV unset, too.
>
> Introduced by 77ec494490d60d89b42cd01d5dbf8dee04503623
> ("batman-adv: Announce new capability via multicast TVLV")
>
> Reported-by: Tobias Hachmer <tobias@hachmer.de>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
> multicast.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Applied in revision 33fdd2c.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-11-16 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 4:40 [B.A.T.M.A.N.] [PATCHv2 0/2] fixes for multicast counter imbalances Linus Lüssing
2014-10-30 4:40 ` [B.A.T.M.A.N.] [PATCHv2 1/2] batman-adv: fix counter for multicast supporting nodes Linus Lüssing
2014-11-16 8:53 ` Marek Lindner [this message]
2014-10-30 4:40 ` [B.A.T.M.A.N.] [PATCHv2 2/2] batman-adv: fix multicast counter when purging originators Linus Lüssing
2014-11-16 8:55 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1676843.nBZ6j67u22@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).