b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@open-mesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Store and transmit own neighborhood hash
Date: Thu, 29 Sep 2016 18:05:22 +0200	[thread overview]
Message-ID: <1927845.coqzugHYhY@sven-edge> (raw)
In-Reply-To: <20160920121245.593-2-linus.luessing@c0d3.blue>

[-- Attachment #1: Type: text/plain, Size: 1734 bytes --]

On Dienstag, 20. September 2016 14:12:43 CEST Linus Lüssing wrote:
[...]
>  /**
> + * batadv_v_elp_update_neigh_hash - updates neighborhood hash related data
> + * @hard_iface: interface which the data has to be prepared for
> + *
> + * Firstly, this function updates the neighborhood hash of a hard interface.
> + * That is it resummarizes the present neighborhood into one compact hash
> + * representation.
> + *
> + * Secondly, minimum and maximum throughput values within this neighorhood are
> + * updated.
> + */
> +static void batadv_v_elp_update_neigh_hash(struct batadv_hard_iface *hard_iface)
> +{
> +	struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
> +	struct batadv_hardif_neigh_node *hardif_neigh;
> +	struct ewma_throughput *ewma_throughput;
> +	u8 *own_addr = hard_iface->net_dev->dev_addr;
> +	u32 min_throughput = ~((u32)0), max_throughput = 0;
> +	u32 throughput;
> +	int ret;
> +
> +	SHASH_DESC_ON_STACK(shash, tfm);

This macro doesn't exist on Linux < v3.18. Can you please add it to
compat-include/crypto/hash.h?

[...]
> +/**
> + * batadv_tvlv_nhh_data - neighborhood hash data
> + * @min_throughput: worst of all TX throughputs this neighbor has to others
> + * @max_throughput: best of all TX throughputs this neighbor has to others
> + * @neigh_hash: a sha512 hash of all neighbors this neighbor sees
> + *  (hash over the alphabetically ordered, concatenated, binary representation)
> + */
> +struct batadv_tvlv_nhh_data {
> +	__be32 min_throughput;
> +	__be32 max_throughput;
> +	u8 neigh_hash[SHA512_DIGEST_SIZE];
> +};
> +

Please use "struct batadv_tvlv_nhh_data - neighborhood hash data" in
kernel-doc block


Kind regards,
	Sven


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  parent reply	other threads:[~2016-09-29 16:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 12:12 [B.A.T.M.A.N.] Broadcast Avoidances, Neighborhood Hash Linus Lüssing
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Store and transmit own neighborhood hash Linus Lüssing
2016-09-20 13:01   ` Sven Eckelmann
2016-09-29 15:31   ` Sven Eckelmann
2016-10-06  1:55     ` Linus Lüssing
2016-10-06  3:03       ` Linus Lüssing
2016-10-06 15:41     ` Linus Lüssing
2016-09-29 16:05   ` Sven Eckelmann [this message]
2016-09-29 16:39   ` Sven Eckelmann
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Introduce packet type independent TVLV handler API Linus Lüssing
2016-09-29 16:05   ` Sven Eckelmann
2016-09-29 16:46   ` Sven Eckelmann
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Evaluate and use neighborhood hash TVLV Linus Lüssing
2016-09-29 15:48   ` Sven Eckelmann
2016-09-29 16:05   ` Sven Eckelmann
2016-09-29 16:55   ` Sven Eckelmann
2016-09-20 12:23 ` [B.A.T.M.A.N.] Broadcast Avoidances, Neighborhood Hash Linus Lüssing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1927845.coqzugHYhY@sven-edge \
    --to=sven.eckelmann@open-mesh.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).