b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.net>
Subject: Re: [B.A.T.M.A.N.] /proc vis rework
Date: Sun, 20 Dec 2009 01:01:55 +0800	[thread overview]
Message-ID: <200912200101.55746.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20091130211445.GN4150@lunn.ch>


Hey,

> A while back i suggested we re-work the /proc/net/batman/vis format.
> Attached are two patches to achieve this. One patch is for the kernel
> model sources and the second extends batctl so that it can read from
> the /proc file and output dot or json format as before. The patch
> includes documentation for the new new batctl command in the man page.

I reviewed the patches & fixed some issues:
* vis raw data (kernel): I upgraded the patch to make it apply on the latest 
trunk and added a descriptive commit message
* vis raw data (batctl): I did not change anything but I'd like to suggest we 
adapt the coding style to match the rest of batctl (maybe using Lindent?). 
Also, all other batctl modules follow the same behaviour regarding the "-h" 
option. To be consistent we may want to adapt that as well.
* vis_format remove: This patch removed the vis_format initializations but not 
the corresponding free calls. I fixed that.
* I added an additional patch (splitting /proc vis file into vis_server and 
vis_data) to follow the roadmap we layed out in Brussels.
* Last but not least: the mandatory batctl vis data path change

Please give it some more testing,
Marek

  parent reply	other threads:[~2009-12-19 17:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 21:14 [B.A.T.M.A.N.] /proc vis rework Andrew Lunn
2009-12-11 22:58 ` Linus Lüssing
2009-12-11 23:20   ` Linus Lüssing
2009-12-12 10:43   ` Andrew Lunn
2009-12-13 16:14   ` Andrew Lunn
2009-12-13 16:11 ` Andrew Lunn
2009-12-13 20:02   ` Linus Lüssing
2009-12-19 17:01 ` Marek Lindner [this message]
2009-12-19 17:11   ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: moving vis output formats out of the kernel land Marek Lindner
2009-12-19 17:11     ` [B.A.T.M.A.N.] [PATCH 2/5] batctl: Parse the new /proc vis format Marek Lindner
2009-12-19 17:11       ` [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: remove obsoleted vis_format /proc file Marek Lindner
2009-12-19 17:11         ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: splitting /proc vis file into vis_server and vis_data Marek Lindner
2009-12-19 17:11           ` [B.A.T.M.A.N.] [PATCH 5/5] batctl: adjust vis data file path Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912200101.55746.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).