From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality
Date: Tue, 19 Jan 2010 18:44:17 +0100 [thread overview]
Message-ID: <20100119174417.GJ24649@lunn.ch> (raw)
In-Reply-To: <201001190812.49887.lindner_marek@yahoo.de>
On Tue, Jan 19, 2010 at 08:12:49AM +0800, Marek Lindner wrote:
> On Monday 18 January 2010 23:24:26 Andrew Lunn wrote:
> > gw_node_update() is missing a rcu_read_unlock(); before the return
> > inside the list_for_each_entry_rcu() loop. The others are less
> > serious, but should be corrected as well.
>
> Thanks - I just fixed it.
>
> What does this error message want to tell us ?
> batman-adv-kernelland/routing.c:966:5: warning: context imbalance in
> 'recv_unicast_packet' - different lock contexts for basic block
I've never spent the time to read the sparse documentation to figure
out exactly what this means. Just from experience i know it is trying
to tell us the locks don't balance in some code path. ie the number of
locks don't equal the number of unlocks. It is not the friendliest of
warning messages.
Andrew
next prev parent reply other threads:[~2010-01-19 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 18:27 [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality Simon Wunderlich
2010-01-17 20:15 ` Simon Wunderlich
2010-01-18 11:31 ` Marek Lindner
2010-01-18 15:15 ` Andrew Lunn
2010-01-18 15:24 ` Andrew Lunn
2010-01-19 0:12 ` Marek Lindner
2010-01-19 17:44 ` Andrew Lunn [this message]
2010-01-18 22:57 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119174417.GJ24649@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).