b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Update pointer to ethhdr after skb_copy
Date: Mon, 26 Apr 2010 11:24:13 +0200	[thread overview]
Message-ID: <201004261124.19573.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <201004261659.20055.lindner_marek@yahoo.de>

[-- Attachment #1: Type: Text/Plain, Size: 814 bytes --]

Marek Lindner wrote:
> > @@ -1106,6 +1110,7 @@ int recv_unicast_packet(struct sk_buff *skb)
> > 
> >  		if (!skb)
> >  		
> >  			return NET_RX_DROP;
> >  		
> >  		unicast_packet = (struct unicast_packet *) skb->data;
> > 
> > +		ethhdr = (struct ethhdr *)skb_mac_header(skb);
> > 
> >  		kfree_skb(skb_old);
> >  	
> >  	}
> 
> I was about to commit your patch when I fell over these last 2 changes. I
> can't see why we need them. What did I miss ?

They are not really needed, but just wanted to have them in for later usage 
and to have it more consistent (otherwise copy and paste easily leads to funny 
effects for some people which cannot be reproduced by the maintainers). So it 
could be removed in recv_icmp_packet and recv_unicast_packet if you prefer it.

Best regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2010-04-26  9:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-25 23:24 [B.A.T.M.A.N.] [PATCH] batman-adv: Update pointer to ethhdr after skb_copy Sven Eckelmann
2010-04-26  8:59 ` Marek Lindner
2010-04-26  9:24   ` Sven Eckelmann [this message]
2010-04-26 10:27     ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004261124.19573.sven.eckelmann@gmx.de \
    --to=sven.eckelmann@gmx.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=lindner_marek@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).