From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] Staging: batman-adv: send.c: Checkpatch cleanup
Date: Sat, 1 May 2010 16:12:15 +0200 [thread overview]
Message-ID: <20100501141215.GO3734@lunn.ch> (raw)
In-Reply-To: <1272721576-9372-1-git-send-email-sven.eckelmann@gmx.de>
On Sat, May 01, 2010 at 03:46:16PM +0200, Sven Eckelmann wrote:
> From: Andrea Gelmini <andrea.gelmini@gelma.net>
>
> drivers/staging/batman-adv/send.c:137: CHECK: multiple assignments should be avoided
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> drivers/staging/batman-adv/send.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/batman-adv/send.c b/drivers/staging/batman-adv/send.c
> index 2a9fac8..ff7b1f1 100644
> --- a/drivers/staging/batman-adv/send.c
> +++ b/drivers/staging/batman-adv/send.c
> @@ -134,7 +134,8 @@ static void send_packet_to_if(struct forw_packet *forw_packet,
> if (batman_if->if_active != IF_ACTIVE)
> return;
>
> - packet_num = buff_pos = 0;
> + packet_num = 0;
> + buff_pos = 0;
> batman_packet = (struct batman_packet *)
> (forw_packet->packet_buff);
>
> --
I was too lazy to go searching upstream. We can just import this patch
and use your three checkpatch patches.
Andrew
next prev parent reply other threads:[~2010-05-01 14:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 13:10 [B.A.T.M.A.N.] [PATCH 0/4] *** SUBJECT HERE *** Andrew Lunn
2010-05-01 13:10 ` [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Update README to match mainline README Andrew Lunn
2010-05-01 13:53 ` Sven Eckelmann
2010-05-01 14:26 ` Andrew Lunn
2010-05-01 13:10 ` [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Import sparse fixes from mainline Andrew Lunn
2010-05-01 16:34 ` Sven Eckelmann
2010-05-01 16:48 ` Andrew Lunn
2010-05-01 17:13 ` Marek Lindner
2010-05-01 18:10 ` Sven Eckelmann
2010-05-01 13:10 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: whitespace " Andrew Lunn
2010-05-01 13:33 ` Sven Eckelmann
2010-05-01 13:46 ` [B.A.T.M.A.N.] [PATCH] Staging: batman-adv: send.c: Checkpatch cleanup Sven Eckelmann
2010-05-01 14:12 ` Andrew Lunn [this message]
2010-05-01 14:10 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: whitespace fixes from mainline Andrew Lunn
2010-05-01 13:10 ` [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit Andrew Lunn
2010-05-01 13:28 ` Sven Eckelmann
2010-05-01 14:05 ` Andrew Lunn
2010-05-01 17:14 ` [B.A.T.M.A.N.] [PATCH 0/4] *** SUBJECT HERE *** Marek Lindner
2010-05-01 18:17 ` Andrew Lunn
2010-05-01 18:56 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100501141215.GO3734@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).