b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: devel <devel@driverdev.osuosl.org>,
	b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org,
	Simon Wunderlich <siwu@hrz.tu-chemnitz.de>,
	Joe Perches <joe@perches.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH] drivers/staging/batman-adv: Convert MAC_FMT to %pM
Date: Thu, 3 Jun 2010 07:45:04 -0700	[thread overview]
Message-ID: <20100603144504.GC17831@suse.de> (raw)
In-Reply-To: <201006031715.54584.lindner_marek@yahoo.de>

On Thu, Jun 03, 2010 at 05:15:53PM +0800, Marek Lindner wrote:
> On Thursday 03 June 2010 08:20:01 Joe Perches wrote:
> > The patch changes the prefix from "batman-adv:" to "batman_adv: "
> > so yes, it would break as-is.
> > 
> > I think the concept is broken though, I believe dmesg output
> > specifically is not guaranteed to remain stable, and batman should
> > use some other, perhaps private, logger based on ethtool events.
> 
> I think changing a dash to an underscore is not such a big deal (I did not 
> check the rest of the patch yet). But I'm interested to hear more about your 
> "private logger" idea because the current solution is far from being perfect. 
> As we have to debug the routing protocol every now and then it would be very 
> helpful to get direct access to some internal logging facility. In fact, that 
> existed before (inside of /proc) but was removed to be more compliant with the 
> linux kernel and the existing log facilities.

You can always use debugfs if you like for something like this.

Or tie into the profile/perf subsystem, that might be even easier.

thanks,

greg k-h

  reply	other threads:[~2010-06-03 14:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02 20:10 [B.A.T.M.A.N.] [PATCH] drivers/staging/batman-adv: Convert MAC_FMT to %pM Joe Perches
2010-06-02 23:23 ` Sven Eckelmann
2010-06-02 23:32   ` Joe Perches
2010-06-02 23:33     ` Sven Eckelmann
2010-06-02 23:47       ` Joe Perches
2010-06-02 23:56         ` Sven Eckelmann
2010-06-03  0:20           ` Joe Perches
2010-06-03  9:15             ` Marek Lindner
2010-06-03 14:45               ` Greg KH [this message]
2010-06-03 13:58 ` Sven Eckelmann
2010-06-03 14:39 ` [B.A.T.M.A.N.] [PATCH-trunk] " Sven Eckelmann
2010-06-03 14:44   ` [B.A.T.M.A.N.] [PATCH-maint] " Sven Eckelmann
2010-06-03 14:51   ` [B.A.T.M.A.N.] [PATCH-trunk] " Sven Eckelmann
2010-06-04 14:18 ` [B.A.T.M.A.N.] [PATCHv2-trunk] batman-adv: " Sven Eckelmann
2010-06-04 14:19   ` Sven Eckelmann
2010-06-04 14:24   ` [B.A.T.M.A.N.] [PATCHv2-maint] " Sven Eckelmann
2010-06-05 17:44   ` [B.A.T.M.A.N.] [PATCHv2-trunk] " Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100603144504.GC17831@suse.de \
    --to=gregkh@suse.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=joe@perches.com \
    --cc=lindner_marek@yahoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=siwu@hrz.tu-chemnitz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).