b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: layer2 unicast packet fragmentation
Date: Fri, 9 Jul 2010 16:51:25 +0200	[thread overview]
Message-ID: <201007091651.27867.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <1278523926-29219-2-git-send-email-an.langer@gmx.de>

[-- Attachment #1: Type: Text/Plain, Size: 2304 bytes --]

Andreas Langer wrote:
> +	if (atomic_read(&bat_priv->frag_enabled) && batman_if->net_dev->mtu <
> +		ETH_DATA_LEN + BAT_HEADER_LEN)
> +		bat_info(soft_device,
> +			"The MTU of interface %s is too small (%zi) to handle "
> +			"the transport of batman-adv packets. Packets going "
> +			"over this interface will be fragmented on layer2 "
> +			"which could impact the performance. Setting the MTU "
> +			"to %zi would solve the problem.\n",
> +			batman_if->dev, batman_if->net_dev->mtu,
> +			ETH_DATA_LEN + BAT_HEADER_LEN);
> +
> +	if (!atomic_read(&bat_priv->frag_enabled) && batman_if->net_dev->mtu <
> +		ETH_DATA_LEN + BAT_HEADER_LEN)
> +		bat_info(soft_device,
> +			"The MTU of interface %s is too small (%zi) to handle "
> +			"the transport of batman-adv packets. If you experience"
> +			" problems getting traffic through try increasing the "
> +			"MTU to %zi.\n",
> +			batman_if->dev, batman_if->net_dev->mtu,
> +			ETH_DATA_LEN + BAT_HEADER_LEN);
> +
>  	if (hardif_is_iface_up(batman_if))
>  		hardif_activate_interface(soft_device, bat_priv, batman_if);


Nach der Aenderung der Argumente muesstest du das erste %zi wieder in ein %i
umaendern:

diff --git a/batman-adv/hard-interface.c b/batman-adv/hard-interface.c
index 1177e93..9dbbe2b 100644
--- a/batman-adv/hard-interface.c
+++ b/batman-adv/hard-interface.c
@@ -276,7 +276,7 @@ int hardif_enable_interface(struct batman_if *batman_if)
 	if (atomic_read(&bat_priv->frag_enabled) && batman_if->net_dev->mtu <
 		ETH_DATA_LEN + BAT_HEADER_LEN)
 		bat_info(soft_device,
-			"The MTU of interface %s is too small (%zi) to handle "
+			"The MTU of interface %s is too small (%i) to handle "
 			"the transport of batman-adv packets. Packets going "
 			"over this interface will be fragmented on layer2 "
 			"which could impact the performance. Setting the MTU "
@@ -287,7 +287,7 @@ int hardif_enable_interface(struct batman_if *batman_if)
 	if (!atomic_read(&bat_priv->frag_enabled) && batman_if->net_dev->mtu <
 		ETH_DATA_LEN + BAT_HEADER_LEN)
 		bat_info(soft_device,
-			"The MTU of interface %s is too small (%zi) to handle "
+			"The MTU of interface %s is too small (%i) to handle "
 			"the transport of batman-adv packets. If you experience"
 			" problems getting traffic through try increasing the "
 			"MTU to %zi.\n",

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2010-07-09 14:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 17:30 [B.A.T.M.A.N.] batman adv unicast fragmentation (version 5) Andreas Langer
2010-07-07 17:32 ` [B.A.T.M.A.N.] [PATCH 1/2] batctl: layer2 unicast packet fragmentation Andreas Langer
2010-07-07 17:32 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: " Andreas Langer
2010-07-09 14:51   ` Sven Eckelmann [this message]
2010-07-11 14:37 ` [B.A.T.M.A.N.] batman adv unicast fragmentation (version 5) Marek Lindner
  -- strict thread matches above, loose matches on Subject: below --
2010-07-06 15:58 [B.A.T.M.A.N.] batman adv unicast fragmentation (version 4) Andreas Langer
2010-07-06 15:59 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: layer2 unicast packet fragmentation Andreas Langer
2010-07-06 17:07   ` Andrew Lunn
2010-07-06 18:06     ` Andreas Langer
2010-07-06 17:39   ` Antonio Quartulli
2010-07-06 18:17     ` Andreas Langer
2010-07-06 18:57     ` Andrew Lunn
2010-07-06 19:13       ` Sven Eckelmann
2010-07-06 19:50         ` Marek Lindner
2010-07-07 10:40   ` Marek Lindner
2010-07-05 21:42 [B.A.T.M.A.N.] batman adv unicast fragmentation (version 3) Andreas Langer
2010-07-05 21:44 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: layer2 unicast packet fragmentation Andreas Langer
2010-06-30 18:58 [B.A.T.M.A.N.] batman adv unicast fragmentation Andreas Langer
2010-06-30 19:00 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: layer2 unicast packet fragmentation Andreas Langer
2010-07-05  0:37   ` Sven Eckelmann
2010-07-05 12:53   ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007091651.27867.sven.eckelmann@gmx.de \
    --to=sven.eckelmann@gmx.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).