From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: softif lan loop avoidance
Date: Wed, 29 Sep 2010 13:44:24 +0200 [thread overview]
Message-ID: <201009291344.24774.lindner_marek@yahoo.de> (raw)
In-Reply-To: <201009282323.07115.sven.eckelmann@gmx.de>
On Tuesday 28 September 2010 23:23:03 Sven Eckelmann wrote:
> Do you want to change the other _hold and _put functions to make it
> consistent in batman-adv regarding the NULL pointer checks?
Yes, I will send patches for that.
> You must protect the whole loop and not only the hlist_del_rcu with the
> bat_priv->softif_neigh_lock, And it must be with spin_lock_irqsave because
> you use it in context were irq is disabled and in some with enabled irq
> contexts... or am I wrong?
No, you are right - I will add the irq locks.
> Can you mark that function as static?
Done.
Thanks for your review,
Marek
next prev parent reply other threads:[~2010-09-29 11:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 18:57 [B.A.T.M.A.N.] LAN loop avoidance (part II) Marek Lindner
2010-09-26 18:57 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: softif lan loop avoidance Marek Lindner
2010-09-26 19:16 ` [B.A.T.M.A.N.] " Lew Pitcher
2010-09-26 20:25 ` Marek Lindner
2010-09-27 0:25 ` DuncanSF
2010-09-27 1:22 ` Donald Gordon
2010-09-27 15:58 ` Marek Lindner
2010-09-27 21:00 ` Donald Gordon
2010-09-28 9:33 ` Marek Lindner
2010-09-28 21:23 ` [B.A.T.M.A.N.] [PATCH 1/2] " Sven Eckelmann
2010-09-29 11:44 ` Marek Lindner [this message]
2010-09-26 18:57 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: display soft-interface neighbor table Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009291344.24774.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).