From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: fixed hash functions type to uint32_t instead of int
Date: Wed, 12 Oct 2011 17:24:41 +0200 [thread overview]
Message-ID: <201110121724.42282.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1317827125-22776-1-git-send-email-ordex@autistici.org>
On Wednesday, October 05, 2011 17:05:25 Antonio Quartulli wrote:
> There are two reasons for this fix:
> - the result of choose_orig() and vis_choose() is an index and therefore it
> can't be negative. Hence it is correct to make the return type unsigned
> too.
>
> - sizeof(int) may not be the same on ALL the architectures. Since we plan
> to use choose_orig() as DHT hash function, we need to guarantee that,
> given the same argument, the result is the same. Then it is correct to
> explicitly express the size of the return type (and the second argument).
> Since the expected length is currently 4, uint32_t is the most convenient
> choice.
Applied in revision 3a0a234.
Thanks,
Marek
prev parent reply other threads:[~2011-10-12 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 22:12 [B.A.T.M.A.N.] [PATCH] batman-adv: fixed hash functions type to uint32_t instead of int Antonio Quartulli
2011-10-05 14:01 ` [B.A.T.M.A.N.] [PATCHv2] " Antonio Quartulli
2011-10-05 15:05 ` [B.A.T.M.A.N.] [PATCHv3] " Antonio Quartulli
2011-10-12 15:24 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110121724.42282.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).