From: David Miller <davem@davemloft.net>
To: lindner_marek@yahoo.de
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
stable@kernel.org
Subject: Re: [B.A.T.M.A.N.] pull request: batman-adv 2011-10-29
Date: Sun, 30 Oct 2011 03:07:45 -0400 (EDT) [thread overview]
Message-ID: <20111030.030745.1245988853394270780.davem@davemloft.net> (raw)
In-Reply-To: <1319875606-7794-1-git-send-email-lindner_marek@yahoo.de>
From: Marek Lindner <lindner_marek@yahoo.de>
Date: Sat, 29 Oct 2011 10:06:43 +0200
> git://git.open-mesh.org/linux-merge.git batman-adv/maint
Pulled, but long term you should shore up your datastructures to
handle that issue in patch #3.
Make a common header:
struct tt_entry_common {
u8 addr[ETH_ALEN];
struct hlist_node hash_entry;
};
Then use that at the beginning of both structures:
struct tt_local_entry {
struct tt_entry_common common;
unsigned long last_seen;
...
};
struct tt_global_entry {
struct tt_entry_comomn common;
struct orig_node *orig_node;
...
};
And &p->common is what gets passed into tt_response_fill_table().
next prev parent reply other threads:[~2011-10-30 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-29 8:06 [B.A.T.M.A.N.] pull request: batman-adv 2011-10-29 Marek Lindner
2011-10-29 8:06 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: remove references for global tt entries Marek Lindner
2011-10-29 8:06 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: add sanity check when removing global tts Marek Lindner
2011-10-29 8:06 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: unify hash_entry field position in tt_local/global_entry Marek Lindner
2011-10-30 7:07 ` David Miller [this message]
2011-10-30 9:05 ` [B.A.T.M.A.N.] pull request: batman-adv 2011-10-29 Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111030.030745.1245988853394270780.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).