From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: implement an helper function to forge unicast packets
Date: Mon, 31 Oct 2011 01:05:46 +0100 [thread overview]
Message-ID: <20111031000546.GC10726@pandem0nium> (raw)
In-Reply-To: <1319964962-5092-2-git-send-email-ordex@autistici.org>
[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]
On Sun, Oct 30, 2011 at 09:55:57AM +0100, Antonio Quartulli wrote:
> @@ -304,33 +331,22 @@ int unicast_send_skb(struct sk_buff *skb, struct bat_priv *bat_priv)
> orig_node = transtable_search(bat_priv, ethhdr->h_source,
> ethhdr->h_dest);
>
> -find_router:
> +prepare_packet:
> /**
> * find_router():
I guess the comment should be changed as well when the label is renamed.
> * - if orig_node is NULL it returns NULL
> * - increases neigh_nodes refcount if found.
> */
> neigh_node = find_router(bat_priv, orig_node, NULL);
> -
Do we really need to remove this newline?
> if (!neigh_node)
> goto out;
>
> - if (my_skb_head_push(skb, sizeof(*unicast_packet)) < 0)
> + skb = prepare_unicast_packet(skb, orig_node);
> + if (!skb)
> goto out;
>
> unicast_packet = (struct unicast_packet *)skb->data;
>
> - unicast_packet->version = COMPAT_VERSION;
> - /* batman packet type: unicast */
> - unicast_packet->packet_type = BAT_UNICAST;
> - /* set unicast ttl */
> - unicast_packet->ttl = TTL;
> - /* copy the destination for faster routing */
> - memcpy(unicast_packet->dest, orig_node->orig, ETH_ALEN);
> - /* set the destination tt version number */
> - unicast_packet->ttvn =
> - (uint8_t)atomic_read(&orig_node->last_ttvn);
> -
> if (atomic_read(&bat_priv->fragmentation) &&
> data_len + sizeof(*unicast_packet) >
> neigh_node->if_incoming->net_dev->mtu) {
> @@ -350,7 +366,7 @@ out:
> neigh_node_free_ref(neigh_node);
> if (orig_node)
> orig_node_free_ref(orig_node);
> - if (ret == 1)
> + if (ret == 1 && skb)
> kfree_skb(skb);
> return ret;
> }
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-10-31 0:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 8:55 [B.A.T.M.A.N.] [PATCH 0/6] DAT: Distributed ARP Table Antonio Quartulli
2011-10-30 8:55 ` [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: implement an helper function to forge unicast packets Antonio Quartulli
2011-10-31 0:05 ` Simon Wunderlich [this message]
2011-11-01 9:12 ` Antonio Quartulli
2011-10-30 8:55 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: add a new log level for DAT-ARP debugging Antonio Quartulli
2011-10-30 8:55 ` [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: Distributed ARP Table - create the DHT helper functions Antonio Quartulli
2011-10-31 0:08 ` Simon Wunderlich
2011-10-30 8:56 ` [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: Distributed ARP Table - add ARP parsing functions Antonio Quartulli
2011-10-31 0:10 ` Simon Wunderlich
2011-11-01 9:14 ` Antonio Quartulli
2011-10-30 8:56 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli
2011-10-30 9:18 ` Sven Eckelmann
2011-10-30 9:29 ` Antonio Quartulli
2011-10-31 0:12 ` Simon Wunderlich
2011-11-01 9:16 ` Antonio Quartulli
2011-10-30 8:56 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: Distributed ARP Table - increase default soft_iface ARP table timeout Antonio Quartulli
2011-10-31 0:03 ` [B.A.T.M.A.N.] [PATCH 0/6] DAT: Distributed ARP Table Simon Wunderlich
2011-10-31 9:26 ` Martin Hundebøll
2011-10-31 9:42 ` Marek Lindner
2011-10-31 9:48 ` Simon Wunderlich
2011-11-01 9:16 ` Antonio Quartulli
2011-10-31 18:53 ` Gus Wirth
2011-10-31 23:11 ` Simon Wunderlich
2011-11-01 9:10 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031000546.GC10726@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).