From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 4/7] batman-adv: Distributed ARP Table - add ARP parsing functions
Date: Wed, 23 Nov 2011 16:47:01 +0100 [thread overview]
Message-ID: <20111123154701.GB2656@lunn.ch> (raw)
In-Reply-To: <1321915993-29312-5-git-send-email-ordex@autistici.org>
On Mon, Nov 21, 2011 at 11:53:10PM +0100, Antonio Quartulli wrote:
Hi Antonio
> +/* Returns arphdr->ar_op if the skb contains a valid ARP packet, otherwise
> + * returns 0 */
> +uint16_t arp_get_type(struct bat_priv *bat_priv, struct sk_buff *skb)
> +{
> + struct arphdr *arphdr;
> + struct ethhdr *ethhdr;
> + uint16_t type = 0;
> + char buf[30], *type_str[] = { "REQUEST", "REPLY", "RREQUEST", "RREPLY",
> + "InREQUEST", "InREPLY", "NAK" };
type_str could be marked as const. Saves a little bit of space on the
BSS.
> +
> + if (type >= 1 && type <= 10)
> + scnprintf(buf, 30, "%s", type_str[type - 1]);
type_str currently has 6 entries, so if somebody sends you an ARP
request with type greater than 6, you go off the end of the
array. Better to use ARRAY_SIZE().
Andrew
next prev parent reply other threads:[~2011-11-23 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 22:53 [B.A.T.M.A.N.] [PATCHv3 0/7] DAT: Distributed ARP Table Antonio Quartulli
2011-11-21 22:53 ` [B.A.T.M.A.N.] [PATCHv3 1/7] batman-adv: implement an helper function to forge unicast packets Antonio Quartulli
2011-11-21 22:53 ` [B.A.T.M.A.N.] [PATCHv3 2/7] batman-adv: add a new log level for DAT-ARP debugging Antonio Quartulli
2011-11-21 22:53 ` [B.A.T.M.A.N.] [PATCHv3 3/7] batman-adv: Distributed ARP Table - create the DHT helper functions Antonio Quartulli
2011-11-21 22:53 ` [B.A.T.M.A.N.] [PATCHv3 4/7] batman-adv: Distributed ARP Table - add ARP parsing functions Antonio Quartulli
2011-11-23 15:47 ` Andrew Lunn [this message]
2011-11-21 22:53 ` [B.A.T.M.A.N.] [PATCHv3 5/7] batman-adv: Distributed ARP Table - add snooping functions for ARP messages Antonio Quartulli
2011-11-23 16:11 ` Andrew Lunn
2011-11-23 16:19 ` Antonio Quartulli
2011-11-21 22:53 ` [B.A.T.M.A.N.] [PATCHv3 6/7] batman-adv: Distributed ARP Table - increase default soft_iface ARP table timeout Antonio Quartulli
2011-11-21 22:53 ` [B.A.T.M.A.N.] [PATCHv3 7/7] batman-adv: add Distributed ARP Table compile option Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123154701.GB2656@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).