From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: convert batman iv algorithm to use dynamic infrastructure
Date: Tue, 6 Dec 2011 20:20:01 +0100 [thread overview]
Message-ID: <20111206192001.GA18458@pandem0nium> (raw)
In-Reply-To: <201112050400.48933.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On Mon, Dec 05, 2011 at 04:00:48AM +0800, Marek Lindner wrote:
> > > + void (*bat_ogm_init)(struct hard_iface *hard_iface);
> > > + void (*bat_ogm_init_primary)(struct hard_iface *hard_iface);
> > > + void (*bat_ogm_update_mac)(struct hard_iface *hard_iface);
> > > + void (*bat_ogm_schedule)(struct hard_iface *hard_iface,
> > > + int tt_num_changes);
> >
> > can't we put tt_num_changes somewhere bat_priv?
>
> tt_num_changes holds the number of changed TT entries since the last OGM.
> Obviously that changes all the time. Are you suggesting we store this value in
> bat_priv instead of a local variable ?
>
Yup. I know that it is changed all the time, just as tt_buff and tt_len changes
- it is updated when the packet is generated.
There is not really a technical advantage (or disadvantage), it would just be
more clean if information like this is stored in bat_priv IMHO - we fetch other
stuff like the tt buffer or the ogm from structs like bat_priv or hard interfaces.
And maybe we want to change something in this mechanism in the future.
Just my personal opinion ;)
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-12-06 19:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:27 [B.A.T.M.A.N.] [RFC] batman-adv: switch routing algorithm at runtime Marek Lindner
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: add infrastructure to change " Marek Lindner
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: convert batman iv algorithm to use dynamic infrastructure Marek Lindner
2011-11-28 19:02 ` Andrew Lunn
2011-11-28 19:45 ` Marek Lindner
2011-11-29 6:09 ` Andrew Lunn
2011-11-29 6:35 ` Marek Lindner
2011-11-29 8:45 ` Andrew Lunn
2011-11-29 15:23 ` Simon Wunderlich
2011-12-04 20:00 ` Marek Lindner
2011-12-06 19:20 ` Simon Wunderlich [this message]
2011-11-28 16:28 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: allowing changing the routing algorithm via sysfs Marek Lindner
2011-11-28 19:00 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: add infrastructure to change routing algorithm at runtime Andrew Lunn
2011-11-28 18:47 ` [B.A.T.M.A.N.] [RFC] batman-adv: switch " Andrew Lunn
2011-11-28 19:42 ` Marek Lindner
2011-11-29 6:18 ` Andrew Lunn
2011-11-29 6:34 ` Marek Lindner
2011-11-29 8:02 ` Andrew Lunn
2011-12-05 9:56 [B.A.T.M.A.N.] " Marek Lindner
2011-12-05 9:56 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: convert batman iv algorithm to use dynamic infrastructure Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206192001.GA18458@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).