From: Antonio Quartulli <ordex@autistici.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: pass the correct header size to interface_rx
Date: Wed, 1 Feb 2012 08:15:35 +0100 [thread overview]
Message-ID: <20120201071535.GC28554@ritirata.org> (raw)
In-Reply-To: <14133018.uqaqHtSXXJ@sven-laptop.home.narfation.org>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Tue, Jan 31, 2012 at 11:53:33PM +0100, Sven Eckelmann wrote:
> On Tuesday 31 January 2012 22:35:10 Antonio Quartulli wrote:
> > in recv_unicast_frag(), the third parameter of the interface_rx()
> > invocation, which is the size of the current header, is wrongly computed.
>
> Really (actually it is the fourth, but I don't want to talk about that)?
> Wasn't the reassembled unicast packet just a unicast packet and not a
> unicast_frag packet (see frag_merge_packet)?
>
> I could be wrong (didn't checked it), but I just have the feeling that the
> current version could be correct.
I double checked a few second ago and yes, you are right. Once the packet has
been merged again it is a unicast_packet.
So, please guys, drop this patch.
Regards,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2012-02-01 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 21:35 [B.A.T.M.A.N.] [PATCH] batman-adv: pass the correct header size to interface_rx Antonio Quartulli
2012-01-31 21:39 ` Antonio Quartulli
2012-01-31 22:53 ` Sven Eckelmann
2012-02-01 7:15 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201071535.GC28554@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).