b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Quartulli <ordex@autistici.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Initialize lockdep class keys for hashes
Date: Tue, 13 Nov 2012 09:06:22 +0100	[thread overview]
Message-ID: <20121113080622.GJ16547@ritirata.org> (raw)
In-Reply-To: <1352541632-25336-1-git-send-email-ordex@autistici.org>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On Sat, Nov 10, 2012 at 11:00:32AM +0100, Antonio Quartulli wrote:
> Different hashes have the same class key key because they get
> initialised with the same one. For this reason lockdep can create
> false warning when they are used recursively.
> 
> Re-initialise the key for each hash after the invocation to hash_new()
> to avoid this problem.
> 
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>

I was thinking...instead of creating such "a free noise" in udev, we may want to
add a configuration facility so that the user can choose which uevents to enable
and which not..

If we don't do so batman-adv will start throwing uevents even if not needed.

Please, drop this patch. We need some more code here :-)

Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-11-13  8:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-10 10:00 [B.A.T.M.A.N.] [PATCH] batman-adv: Initialize lockdep class keys for hashes Antonio Quartulli
2012-11-13  8:06 ` Antonio Quartulli [this message]
2012-11-13  8:08   ` Antonio Quartulli
2012-12-01 10:46 ` Linus Lüssing
2012-12-01 13:11   ` Marek Lindner
  -- strict thread matches above, loose matches on Subject: below --
2012-03-29 10:34 Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121113080622.GJ16547@ritirata.org \
    --to=ordex@autistici.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).