From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: tvlv - convert tt query packet to use tvlv unicast packets
Date: Tue, 16 Apr 2013 18:40:01 +0200 [thread overview]
Message-ID: <20130416164001.GC20819@ritirata.org> (raw)
In-Reply-To: <1366125995-18034-7-git-send-email-lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
On Tue, Apr 16, 2013 at 11:26:34PM +0800, Marek Lindner wrote:
> Instead of generating TT specific packets the TVLV unicast API is used
> to send translation table data.
>
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
[...]
> -
> - if (batadv_send_skb_to_orig(skb, dst_orig_node, NULL))
> - ret = 0;
> + batadv_tvlv_unicast_send(bat_priv, primary_if->net_dev->dev_addr,
> + dst_orig_node->orig, BATADV_TVLV_TT, 1,
> + (unsigned char *)tvlv_tt_data,
^^^^^^^^^^^^^^^^^
You should remove this cast since the function expects a void *
> + sizeof(*tvlv_tt_data));
> + ret = true;
>
[...]
> - if (batadv_send_skb_to_orig(skb, res_dst_orig_node, NULL))
> - ret = true;
> + batadv_tvlv_unicast_send(bat_priv, req_dst_orig_node->orig,
> + req_src, BATADV_TVLV_TT, 1,
> + (unsigned char *)tvlv_tt_data,
same here.
> + sizeof(*tvlv_tt_data) + tt_len);
> +
> + ret = true;
> goto out;
[...]
> - if (batadv_send_skb_to_orig(skb, orig_node, NULL))
> - ret = true;
> + batadv_tvlv_unicast_send(bat_priv, primary_if->net_dev->dev_addr,
> + req_src, BATADV_TVLV_TT, 1,
> + (unsigned char *)tvlv_tt_data,
same here².
> + sizeof(*tvlv_tt_data) + tt_len);
> +
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-16 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 15:26 [B.A.T.M.A.N.] TVLV infrastructure Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: tvlv - basic infrastructure Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 2/7] batman-adv: tvlv - convert gateway flags Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 3/7] batman-adv: tvlv - add distributed arp table container Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: tvlv - add network coding container Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 5/7] batman-adv: tvlv - convert tt data sent within OGMs Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: tvlv - convert tt query packet to use tvlv unicast packets Marek Lindner
2013-04-16 16:40 ` Antonio Quartulli [this message]
2013-04-16 16:59 ` Marek Lindner
2013-04-16 15:26 ` [B.A.T.M.A.N.] [PATCH 7/7] batman-adv: tvlv - convert roaming adv " Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416164001.GC20819@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).