From: "Linus Lüssing" <linus.luessing@web.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: fix NULL pointer dereferences
Date: Fri, 2 May 2014 06:50:27 +0200 [thread overview]
Message-ID: <20140502045026.GS4593@Linus-Debian> (raw)
In-Reply-To: <1398281948-3415-1-git-send-email-mareklindner@neomailbox.ch>
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
On Thu, Apr 24, 2014 at 03:39:08AM +0800, Marek Lindner wrote:
> Reported-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
> ---
> multicast.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/multicast.c b/multicast.c
> index 8c7ca81..96b66fd 100644
> --- a/multicast.c
> +++ b/multicast.c
> @@ -415,7 +415,7 @@ batadv_mcast_forw_ipv4_node_get(struct batadv_priv *bat_priv)
> hlist_for_each_entry_rcu(tmp_orig_node,
> &bat_priv->mcast.want_all_ipv4_list,
> mcast_want_all_ipv4_node) {
> - if (!atomic_inc_not_zero(&orig_node->refcount))
> + if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
> continue;
>
> orig_node = tmp_orig_node;
> @@ -442,7 +442,7 @@ batadv_mcast_forw_ipv6_node_get(struct batadv_priv *bat_priv)
> hlist_for_each_entry_rcu(tmp_orig_node,
> &bat_priv->mcast.want_all_ipv6_list,
> mcast_want_all_ipv6_node) {
> - if (!atomic_inc_not_zero(&orig_node->refcount))
> + if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
> continue;
>
> orig_node = tmp_orig_node;
> @@ -493,7 +493,7 @@ batadv_mcast_forw_unsnoop_node_get(struct batadv_priv *bat_priv)
> hlist_for_each_entry_rcu(tmp_orig_node,
> &bat_priv->mcast.want_all_unsnoopables_list,
> mcast_want_all_unsnoopables_node) {
> - if (!atomic_inc_not_zero(&orig_node->refcount))
> + if (!atomic_inc_not_zero(&tmp_orig_node->refcount))
> continue;
>
> orig_node = tmp_orig_node;
> --
> 2.0.0.rc0
>
next prev parent reply other threads:[~2014-05-02 4:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 19:39 [B.A.T.M.A.N.] [PATCH] batman-adv: fix NULL pointer dereferences Marek Lindner
2014-04-24 11:59 ` Antonio Quartulli
2014-05-02 4:50 ` Linus Lüssing [this message]
2014-05-27 2:25 [B.A.T.M.A.N.] pull request net: batman-adv 20140527 Antonio Quartulli
2014-05-27 2:25 ` [B.A.T.M.A.N.] [PATCH] batman-adv: fix NULL pointer dereferences Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502045026.GS4593@Linus-Debian \
--to=linus.luessing@web.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).