From: "Linus Lüssing" <linus.luessing@web.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv5 2/2] batman-adv: Add debugfs table for mcast flags
Date: Sat, 2 Aug 2014 21:43:32 +0200 [thread overview]
Message-ID: <20140802194331.GE2392@Linus-Debian> (raw)
In-Reply-To: <1438357.7uXdXc9RPK@diderot>
On Sat, Jul 19, 2014 at 06:02:47PM +0800, Marek Lindner wrote:
> On Tuesday 15 July 2014 04:38:18 Linus Lüssing wrote:
> > + rcu_read_lock();
> > + hlist_for_each_entry_rcu(orig_node, head, hash_entry) {
> > + if (!(orig_node->capa_initialized &
> > + BATADV_ORIG_CAPA_HAS_MCAST))
> > + continue;
>
> Why not printing '-' in this case as well ?
Had been giving a reason on IRC already, but maybe it's better to
write it here again so that the reason doesn't get lost:
The idea was, to only have one entry per batman-adv node. Not per
originator. Secondary interface originators aren't considered in
the multicast logic anyways, so they might be confusing for the
user when doing manual checking and counting.
In other words, '-' is supposed to mean that this is an outdated
node not supporting multicast optimizations and not having the
according TVLV and that people should consider upgrading it.
Cheers, Linus
next prev parent reply other threads:[~2014-08-02 19:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 2:38 [B.A.T.M.A.N.] [PATCHv5 1/2] batman-adv: Add multicast optimization support for bridged setups Linus Lüssing
2014-07-15 2:38 ` [B.A.T.M.A.N.] [PATCHv5 2/2] batman-adv: Add debugfs table for mcast flags Linus Lüssing
2014-07-19 10:02 ` Marek Lindner
2014-07-21 15:29 ` Linus Lüssing
2014-08-02 19:43 ` Linus Lüssing [this message]
2014-07-19 10:11 ` [B.A.T.M.A.N.] [PATCHv5 1/2] batman-adv: Add multicast optimization support for bridged setups Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140802194331.GE2392@Linus-Debian \
--to=linus.luessing@web.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).