b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
* Re: [B.A.T.M.A.N.] [PATCH 3.16 076/294] batman-adv: fix TT sync flag inconsistencies
       [not found] ` <lsq.1510009382.466414456@decadent.org.uk>
@ 2017-11-07  1:16   ` Linus Lüssing
  2017-11-07 13:42     ` Ben Hutchings
  0 siblings, 1 reply; 3+ messages in thread
From: Linus Lüssing @ 2017-11-07  1:16 UTC (permalink / raw)
  To: Ben Hutchings
  Cc: linux-kernel, stable, b.a.t.m.a.n, akpm, Antonio Quartulli,
	Simon Wunderlich

Hi Ben!

On Mon, Nov 06, 2017 at 11:03:02PM +0000, Ben Hutchings wrote:
> 3.16.50-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Linus Lüssing <linus.luessing@c0d3.blue>
> 
> commit 54e22f265e872ae140755b3318521d400a094605 upstream.
[...]
> [bwh: Backported to 3.16:
>  - Drop changes to batadv_tt_global_dump_subentry()

May I ask, were there specific concerns for stable 3.16 kernel
releases with this change?

It's not bothering me, but I'm currently wondering whether
this could cause some confusion to users.

Regards, Linus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH 3.16 076/294] batman-adv: fix TT sync flag inconsistencies
  2017-11-07  1:16   ` [B.A.T.M.A.N.] [PATCH 3.16 076/294] batman-adv: fix TT sync flag inconsistencies Linus Lüssing
@ 2017-11-07 13:42     ` Ben Hutchings
  2017-11-12 19:55       ` Linus Lüssing
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2017-11-07 13:42 UTC (permalink / raw)
  To: Linus Lüssing
  Cc: linux-kernel, stable, b.a.t.m.a.n, akpm, Antonio Quartulli,
	Simon Wunderlich

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

On Tue, 2017-11-07 at 02:16 +0100, Linus Lüssing wrote:
> Hi Ben!
> 
> On Mon, Nov 06, 2017 at 11:03:02PM +0000, Ben Hutchings wrote:
> > 3.16.50-rc1 review patch.  If anyone has any objections, please let
> > me know.
> > 
> > ------------------
> > 
> > From: Linus Lüssing <linus.luessing@c0d3.blue>
> > 
> > commit 54e22f265e872ae140755b3318521d400a094605 upstream.
> 
> [...]
> > [bwh: Backported to 3.16:
> >  - Drop changes to batadv_tt_global_dump_subentry()
> 
> May I ask, were there specific concerns for stable 3.16 kernel
> releases with this change?
>
> It's not bothering me, but I'm currently wondering whether
> this could cause some confusion to users.

That function didn't exist in 3.16 (at least not under that name).

Ben.

-- 
Ben Hutchings
It is impossible to make anything foolproof because fools are so
ingenious.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH 3.16 076/294] batman-adv: fix TT sync flag inconsistencies
  2017-11-07 13:42     ` Ben Hutchings
@ 2017-11-12 19:55       ` Linus Lüssing
  0 siblings, 0 replies; 3+ messages in thread
From: Linus Lüssing @ 2017-11-12 19:55 UTC (permalink / raw)
  To: Ben Hutchings
  Cc: linux-kernel, stable, b.a.t.m.a.n, akpm, Antonio Quartulli,
	Simon Wunderlich

Hi Ben,

On Tue, Nov 07, 2017 at 01:42:35PM +0000, Ben Hutchings wrote:
> That function didn't exist in 3.16 (at least not under that name).

Ah, you're right, back then the netlink interface did not
exist in batman-adv yet, only the debugfs one.
batadv_tt_global_print_entry would be the equivalent function
for debugfs. But not worth the effort now, in my opinion.

I'm fine with this proposed patch for 3.16 now. Thanks for the
clarification! And I'm happy to see this patch backported.

Regards, Linus

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-12 19:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <lsq.1510009377.526284287@decadent.org.uk>
     [not found] ` <lsq.1510009382.466414456@decadent.org.uk>
2017-11-07  1:16   ` [B.A.T.M.A.N.] [PATCH 3.16 076/294] batman-adv: fix TT sync flag inconsistencies Linus Lüssing
2017-11-07 13:42     ` Ben Hutchings
2017-11-12 19:55       ` Linus Lüssing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).