From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH] batctl: netlink: fix resetting mcast_flags_priv to unsupported state
Date: Tue, 20 Mar 2018 02:19:24 +0100 [thread overview]
Message-ID: <20180320011924.28287-1-linus.luessing@c0d3.blue> (raw)
This fixes a copy & paste error detected by Coverity.
Fixes: b56061058113 ("batctl: add netlink dump function for multicast flags table")
Reported-by: scan-admin@coverity.com
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netlink.c b/netlink.c
index ab7be1e..f0fd1d9 100644
--- a/netlink.c
+++ b/netlink.c
@@ -252,7 +252,7 @@ static int info_callback(struct nl_msg *msg, void *arg)
if (attrs[BATADV_ATTR_MCAST_FLAGS_PRIV])
mcast_flags_priv = nla_get_u32(attrs[BATADV_ATTR_MCAST_FLAGS_PRIV]);
else
- mcast_flags = -EOPNOTSUPP;
+ mcast_flags_priv = -EOPNOTSUPP;
switch (opts->nl_cmd) {
case BATADV_CMD_GET_TRANSTABLE_LOCAL:
--
2.11.0
next reply other threads:[~2018-03-20 1:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 1:19 Linus Lüssing [this message]
2018-03-20 7:11 ` [B.A.T.M.A.N.] [PATCH] batctl: netlink: fix resetting mcast_flags_priv to unsupported state Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320011924.28287-1-linus.luessing@c0d3.blue \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).