From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Improve includes for trace functionality
Date: Sun, 21 Oct 2018 11:30:30 +0200 [thread overview]
Message-ID: <20181021093032.19928-4-sven@narfation.org> (raw)
In-Reply-To: <20181021093032.19928-1-sven@narfation.org>
The batadv_dbg trace event uses different functionality and datastructures
which are not directly associated with the trace infrastructure. It should
not be expected that the trace headers indirectly provide them and instead
include the required headers directly.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
net/batman-adv/trace.c | 2 --
net/batman-adv/trace.h | 6 ++++++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/batman-adv/trace.c b/net/batman-adv/trace.c
index 3d57f998..8e102421 100644
--- a/net/batman-adv/trace.c
+++ b/net/batman-adv/trace.c
@@ -16,7 +16,5 @@
* along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
-#include <linux/module.h>
-
#define CREATE_TRACE_POINTS
#include "trace.h"
diff --git a/net/batman-adv/trace.h b/net/batman-adv/trace.h
index 3acda26a..104784be 100644
--- a/net/batman-adv/trace.h
+++ b/net/batman-adv/trace.h
@@ -21,7 +21,13 @@
#include "main.h"
+#include <linux/bug.h>
+#include <linux/kernel.h>
+#include <linux/netdevice.h>
+#include <linux/percpu.h>
+#include <linux/printk.h>
#include <linux/tracepoint.h>
+#include <linux/types.h>
#undef TRACE_SYSTEM
#define TRACE_SYSTEM batadv
--
2.19.1
next prev parent reply other threads:[~2018-10-21 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 9:30 [B.A.T.M.A.N.] [PATCH 0/5] batman-adv: Tracing and debugfs deprecation cleanups Sven Eckelmann
2018-10-21 9:30 ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Drop unused lockdep include Sven Eckelmann
2018-10-21 9:30 ` [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Add includes for deprecation warning Sven Eckelmann
2018-10-21 9:30 ` Sven Eckelmann [this message]
2018-10-21 9:30 ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Allow to use BATMAN_ADV_DEBUG without BATMAN_ADV_DEBUGFS Sven Eckelmann
2018-10-21 9:30 ` [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Fix description for BATMAN_ADV_DEBUG Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181021093032.19928-4-sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).