From: "René Treffer" <treffer@measite.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [PATCH] batman-adv: Use wifi rx/tx as fallback throughput
Date: Sun, 9 Jun 2019 12:19:22 +0200 [thread overview]
Message-ID: <20190609101922.2366-1-treffer@measite.de> (raw)
From: rtreffer <treffer@measite.de>
Some wifi drivers (e.g. ath10k) provide per-station rx/tx values but no
estimated throughput. Setting a better estimate than the default 1MBit
makes these devices work well with BATMAN V.
Signed-off-by: René Treffer <treffer@measite.de>
---
net/batman-adv/bat_v_elp.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c
index 2614a9ca..ce3b52f1 100644
--- a/net/batman-adv/bat_v_elp.c
+++ b/net/batman-adv/bat_v_elp.c
@@ -68,7 +68,7 @@ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh)
struct ethtool_link_ksettings link_settings;
struct net_device *real_netdev;
struct station_info sinfo;
- u32 throughput;
+ u32 throughput, rx, tx;
int ret;
/* if the user specified a customised value for this interface, then
@@ -107,10 +107,25 @@ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh)
}
if (ret)
goto default_throughput;
- if (!(sinfo.filled & BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT)))
- goto default_throughput;
- return sinfo.expected_throughput / 100;
+ if (sinfo.filled & BIT(NL80211_STA_INFO_EXPECTED_THROUGHPUT)) {
+ return sinfo.expected_throughput / 100;
+ }
+
+ // try to estimate en expected throughput based on reported rx/tx rates
+ // 1/3 of tx or 1/3 of the average of rx and tx, whichever is smaller
+ if (sinfo.filled & BIT(NL80211_STA_INFO_TX_BITRATE)) {
+ tx = cfg80211_calculate_bitrate(&sinfo.txrate);
+ if (sinfo.filled & BIT(NL80211_STA_INFO_RX_BITRATE)) {
+ rx = cfg80211_calculate_bitrate(&sinfo.rxrate);
+ if (rx < tx) {
+ return (rx + tx) / 6;
+ }
+ }
+ return tx / 3;
+ }
+
+ goto default_throughput;
}
/* if not a wifi interface, check if this device provides data via
--
2.20.1
next reply other threads:[~2019-06-09 10:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 10:19 René Treffer [this message]
2019-06-09 10:37 ` [PATCH] batman-adv: Use wifi rx/tx as fallback throughput Sven Eckelmann
2019-06-09 11:40 ` Marek Lindner
2019-06-09 12:45 ` René Treffer
2019-06-10 3:31 ` Marek Lindner
2019-06-10 7:37 ` Кирилл Луконин
2019-06-12 6:39 ` Marek Lindner
2019-06-12 20:50 ` Кирилл Луконин
2019-06-25 8:26 ` Marek Lindner
2019-06-27 10:41 ` Кирилл Луконин
2019-06-27 10:57 ` Marek Lindner
2019-06-10 10:06 ` René Treffer
2019-08-11 12:50 ` Marek Lindner
[not found] ` <CALD2-cLnviLCav=Lui9T4Mzz1nnY93kN_0ypd-nhwFUhKNYRQg@mail.gmail.com>
2019-08-11 13:17 ` Marek Lindner
2019-06-09 10:41 ` Sven Eckelmann
2019-06-09 11:09 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609101922.2366-1-treffer@measite.de \
--to=treffer@measite.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).