From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [PATCH maint v3 0/3] batman-adv: mcast: BLA fixes
Date: Mon, 14 Sep 2020 03:21:33 +0200 [thread overview]
Message-ID: <20200914012136.5278-1-linus.luessing@c0d3.blue> (raw)
These are three fixes for issues which occur when using the batman-adv
multicast-to-unicast feature.
They fix issues when using the multicast-to-unicast conversion
while BLA is enabled and some nodes are sharing the same LAN side. Here
it either causes "just" duplicates in the "good" scenario (Patch 3/3).
But can also cause multiple BLA backbones to send a frame from the mesh
into the same, shared LAN segment (Patch 2/3). Or in the worst case, even
reflect packets back to the host in the shared LAN, which completely
confuses switches/bridges and ICMPv6 Neighbor Discovery (Patch 1/3).
Regards, Linus
---
Changelog v3:
* removed 1/4, as it was already applied
* renamed title (excluded TT, as already applied)
* Patch 1/3:
- moved bla-backbone check into multicast code:
-> to stay on the safe side for net, to touch less other code
paths - the issue was observed specifically for multicast
and the fix was tested for that
- added a note regarding implications for mcast-fanout
* Patch 2/3:
- previous approach was broken, it would break the DHCPv6 gateway
code; instead distinguish by batadv 3 vs. 4 addr unicast header
- added some more code comments
- updated commit message with new approach
* Patch 3/3:
- made code a bit more verbose and explicit
- added some more code comments
- added missing kernel doc for "orig" parameter to
new batadv_bla_check_duplist()
Changelog v2:
* Adding "Fixes:" lines
next reply other threads:[~2020-09-14 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 1:21 Linus Lüssing [this message]
2020-09-14 1:21 ` [PATCH maint v3 1/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from LAN Linus Lüssing
2020-09-14 18:12 ` Sven Eckelmann
2020-09-14 1:21 ` [PATCH maint v3 2/3] batman-adv: mcast: fix duplicate mcast packets in BLA backbone from mesh Linus Lüssing
2020-09-14 1:21 ` [PATCH maint v3 3/3] batman-adv: mcast: fix duplicate mcast packets from BLA backbone to mesh Linus Lüssing
2020-09-14 19:12 ` Sven Eckelmann
2020-09-14 18:31 ` [PATCH maint v3 0/3] batman-adv: mcast: BLA fixes Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914012136.5278-1-linus.luessing@c0d3.blue \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).