* [PATCH 1/3] alfred: add missing alfred_event_notify_v0 struct documentation
@ 2022-08-04 18:52 Marek Lindner
2022-08-04 18:52 ` [PATCH 2/3] alfred: fix erroneous documentation of '-r' argument Marek Lindner
2022-08-04 18:52 ` [PATCH 3/3] alfred: mismaching declarations of is_valid_ether_addr() Marek Lindner
0 siblings, 2 replies; 3+ messages in thread
From: Marek Lindner @ 2022-08-04 18:52 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
---
packet.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/packet.h b/packet.h
index b8d528e..c0723b8 100644
--- a/packet.h
+++ b/packet.h
@@ -247,6 +247,7 @@ struct alfred_event_register_v0 {
* struct alfred_event_notify_v0 - event notification message
* @header: TLV header describing the complete packet
* @type: Type of the data triggering the event
+ * @source: Mac address of the original source of the data
*
* Sent by the daemon to client on data record update
*/
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] alfred: fix erroneous documentation of '-r' argument
2022-08-04 18:52 [PATCH 1/3] alfred: add missing alfred_event_notify_v0 struct documentation Marek Lindner
@ 2022-08-04 18:52 ` Marek Lindner
2022-08-04 18:52 ` [PATCH 3/3] alfred: mismaching declarations of is_valid_ether_addr() Marek Lindner
1 sibling, 0 replies; 3+ messages in thread
From: Marek Lindner @ 2022-08-04 18:52 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
---
main.c | 2 +-
man/alfred.8 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/main.c b/main.c
index 3fe7b42..2c3f06e 100644
--- a/main.c
+++ b/main.c
@@ -31,7 +31,7 @@ static void alfred_usage(void)
printf(" -s, --set-data [data type] sets new data to distribute from stdin\n");
printf(" for the supplied data type (0-255)\n");
printf(" -r, --request [data type] collect data from the network and prints\n");
- printf(" it on the network\n");
+ printf(" it on stdout\n");
printf(" -d, --verbose Show extra information in the data output\n");
printf(" -V, --req-version specify the data version set for -s\n");
printf(" -M, --modeswitch primary switch daemon to mode primary\n");
diff --git a/man/alfred.8 b/man/alfred.8
index ca83f02..20c703b 100644
--- a/man/alfred.8
+++ b/man/alfred.8
@@ -67,7 +67,7 @@ must be periodically written again to alfred, otherwise it will timeout and
alfred will forget about it (after 10 minutes).
.TP
\fB\-r\fP, \fB\-\-request\fP \fIdata\-type\fP
-Collect data from the network and prints it on the network
+Collect data from the network and prints it on stdout
.TP
\fB\-d\fP, \fB\-\-verbose\fP
Show extra information in the data output
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] alfred: mismaching declarations of is_valid_ether_addr()
2022-08-04 18:52 [PATCH 1/3] alfred: add missing alfred_event_notify_v0 struct documentation Marek Lindner
2022-08-04 18:52 ` [PATCH 2/3] alfred: fix erroneous documentation of '-r' argument Marek Lindner
@ 2022-08-04 18:52 ` Marek Lindner
1 sibling, 0 replies; 3+ messages in thread
From: Marek Lindner @ 2022-08-04 18:52 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
util.c:57:34: warning: argument 1 of type ‘uint8_t[6]’
{aka ‘unsigned char[6]’} with mismatched bound [-Warray-parameter=]
57 | bool is_valid_ether_addr(uint8_t addr[ETH_ALEN])
| ~~~~~~~~^~~~~~~~~~~~~~
In file included from util.c:20:
alfred.h:231:35: note: previously declared as ‘uint8_t *’
{aka ‘unsigned char *’}
231 | bool is_valid_ether_addr(uint8_t *addr);
| ~~~~~~~~~^~~~
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
---
alfred.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/alfred.h b/alfred.h
index 6fb57ce..97f0093 100644
--- a/alfred.h
+++ b/alfred.h
@@ -228,7 +228,7 @@ int time_diff(struct timespec *tv1, struct timespec *tv2,
struct timespec *tvdiff);
void time_random_seed(void);
uint16_t get_random_id(void);
-bool is_valid_ether_addr(uint8_t *addr);
+bool is_valid_ether_addr(uint8_t addr[ETH_ALEN]);
bool is_iface_disabled(char *iface);
int ipv4_arp_request(struct interface *interface, const alfred_addr *addr,
struct ether_addr *mac);
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-04 18:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 18:52 [PATCH 1/3] alfred: add missing alfred_event_notify_v0 struct documentation Marek Lindner
2022-08-04 18:52 ` [PATCH 2/3] alfred: fix erroneous documentation of '-r' argument Marek Lindner
2022-08-04 18:52 ` [PATCH 3/3] alfred: mismaching declarations of is_valid_ether_addr() Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).