From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v4 1/6] batman-adv: prevent multiple ARP replies sent by gateways if dat enbled
Date: Fri, 13 May 2016 19:37:11 +0200 [thread overview]
Message-ID: <2059800.IKvSZ5WLNp@prime> (raw)
In-Reply-To: <1463034697-8867-2-git-send-email-apape@phoenixcontact.com>
[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]
On Thursday 12 May 2016 08:31:32 Andreas Pape wrote:
> @@ -1003,6 +1004,20 @@ bool batadv_dat_snoop_outgoing_arp_request(struct
> batadv_priv *bat_priv, goto out;
> }
>
> + /* If BLA is enabled, only send ARP replies if we have claimed
> + * the destination for the ARP request or if no one else of
> + * the backbone gws belonging to our backbone has claimed the
> + * destination.
> + */
> + if (!batadv_bla_handle_local_claim(bat_priv,
> + dat_entry->mac_addr, vid)) {
> + batadv_dbg(BATADV_DBG_DAT, bat_priv,
> + "Device %pM claimed by another backbone gw. Don't send ARP
reply!",
> + dat_entry->mac_addr);
> + ret = true;
> + goto out;
> + }
> +
There is still my question/comment pending for this from your PATCHv2. I'll
quote:
I would agree to Antonio that sending a claim is not necessary, and might
actually lead to bad choices of the outgoing backbone gateway. After all, at
this point any "random" backbone gateway may answer to this request, just
because it has the DAT entry, but maybe may actually not be able to reach the
client via the mesh.
I think checking if a local claim exists is a good idea, but sending a claim
is not a good idea - this might introduce effects which will be even more
complicated to debug.
Cheers,
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-13 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 6:31 [B.A.T.M.A.N.] [PATCH v4 0/6] batman-adv: Optimizations for setups running dat and bla Andreas Pape
2016-05-12 6:31 ` [B.A.T.M.A.N.] [PATCH v4 1/6] batman-adv: prevent multiple ARP replies sent by gateways if dat enbled Andreas Pape
2016-05-13 16:45 ` Sven Eckelmann
2016-05-13 17:37 ` Simon Wunderlich [this message]
2016-05-20 10:12 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2016-05-12 6:31 ` [B.A.T.M.A.N.] [PATCH v4 2/6] batman-adv: speed up dat by snooping received ip traffic Andreas Pape
2016-05-12 6:31 ` [B.A.T.M.A.N.] [PATCH v4 3/6] batman-adv: prevent duplication of ARP replies when DAT is used Andreas Pape
2016-05-12 6:31 ` [B.A.T.M.A.N.] [PATCH v4 4/6] batman-adv: drop unicast packets from other backbone gw Andreas Pape
2016-05-12 6:31 ` [B.A.T.M.A.N.] [PATCH v4 5/6] batman-adv: changed debug messages for easier bla debugging Andreas Pape
2016-05-12 6:31 ` [B.A.T.M.A.N.] [PATCH v4 6/6] batman-adv: handle race condition for claims between gateways Andreas Pape
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2059800.IKvSZ5WLNp@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).