From: Sven Eckelmann <sven@narfation.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [v5, 1/2] batman-adv: Remove unused skb_reset_mac_header()
Date: Tue, 18 Oct 2016 15:39:36 +0200 [thread overview]
Message-ID: <2088086.l1VxCJGyzP@bentobox> (raw)
In-Reply-To: <1470566059-3782-1-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On Sonntag, 7. August 2016 12:34:18 CEST Linus Lüssing wrote:
> During broadcast queueing, the skb_reset_mac_header() sets the skb
> to a place invalid for a MAC header, pointing right into the
> batman-adv broadcast packet. Luckily, no one seems to actually use
> eth_hdr(skb) afterwards until batadv_send_skb_packet() resets the
> header to a valid position again.
>
> Therefore removing this unnecessary, weird skb_reset_mac_header()
> call.
>
> Reviewed-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>
> Changes in v2-v5:
> * none
>
> net/batman-adv/send.c | 2 --
> 1 file changed, 2 deletions(-)
Applied in 3d34c0a675b20cf6dd2b8680188f1ebd399c3589 [1].
Kind regards,
Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/3d34c0a675b20cf6dd2b8680188f1ebd399c3589
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-10-18 13:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-07 10:34 [B.A.T.M.A.N.] [PATCH v5 1/2] batman-adv: Remove unused skb_reset_mac_header() Linus Lüssing
2016-08-07 10:34 ` [B.A.T.M.A.N.] [PATCH v5 2/2] batman-adv: Simple (re)broadcast avoidance Linus Lüssing
2016-08-07 16:06 ` Sven Eckelmann
2016-10-19 9:23 ` [B.A.T.M.A.N.] [v5, " Sven Eckelmann
2016-10-20 18:08 ` Linus Lüssing
2016-10-18 13:39 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2088086.l1VxCJGyzP@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).