From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: Re: [PATCH v4 5/5] batman-adv: mcast: shrink tracker packet after scrubbing
Date: Wed, 18 Jan 2023 22:29:10 +0100 [thread overview]
Message-ID: <2573733.TEPBkUXb7U@sven-desktop> (raw)
In-Reply-To: <20221227193409.13461-6-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]
On Tuesday, 27 December 2022 20:34:09 CET Linus Lüssing wrote:
> +/**
> + * batadv_mcast_forw_shrink_move_headers() - move multicast headers by offset
> + * @skb: the batman-adv multicast packet to move headers for
> + * @offset: a non-negative offset to move headers by, towards the skb tail
> + *
> + * Moves the batman-adv multicast packet header, its multicast tracker TVLV and
> + * any TVLVs in between by the given offset in direction towards the tail.
> + *
> + * It also invalidates the skb checksum.
> + */
> +static void
> +batadv_mcast_forw_shrink_move_headers(struct sk_buff *skb, unsigned int offset)
> +{
> + struct batadv_tvlv_mcast_tracker *mcast_tracker;
> + unsigned int tracker_hdrlen, len;
> + unsigned char *skb_net_hdr;
> + u16 num_dests;
> +
> + skb_net_hdr = skb_network_header(skb);
> + mcast_tracker = (struct batadv_tvlv_mcast_tracker *)skb_net_hdr;
> + num_dests = ntohs(mcast_tracker->num_dests);
> + tracker_hdrlen = batadv_mcast_forw_tracker_hdrlen(num_dests);
> + len = skb_network_offset(skb) + tracker_hdrlen;
> +
> + memmove(skb->data + offset, skb->data, len);
> + skb_pull(skb, offset);
> +
> + /* invalidate checksum: */
> + skb->ip_summed = CHECKSUM_NONE;
Shouldn't the invalidation be that already part of the patch 3? At least it
includes receive path processing and modification on the tvlv with the
destination originator addresses.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-18 21:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 19:34 [PATCH v4 0/5] Implementation of a Stateless Multicast Packet Type Linus Lüssing
2022-12-27 19:34 ` [PATCH v4 1/5] batman-adv: mcast: remove now redundant single ucast forwarding Linus Lüssing
2023-01-06 17:21 ` Sven Eckelmann
2022-12-27 19:34 ` [PATCH v4 2/5] batman-adv: tvlv: prepare for tvlv enabled multicast packet type Linus Lüssing
2023-01-06 17:54 ` Sven Eckelmann
2022-12-27 19:34 ` [PATCH v4 3/5] batman-adv: mcast: implement multicast packet reception and forwarding Linus Lüssing
2023-01-15 17:56 ` Sven Eckelmann
2023-01-16 18:31 ` Linus Lüssing
2023-01-19 12:47 ` Simon Wunderlich
2023-01-21 13:15 ` Linus Lüssing
2022-12-27 19:34 ` [PATCH v4 4/5] batman-adv: mcast: implement multicast packet generation Linus Lüssing
2023-01-18 21:15 ` Sven Eckelmann
2022-12-27 19:34 ` [PATCH v4 5/5] batman-adv: mcast: shrink tracker packet after scrubbing Linus Lüssing
2023-01-18 21:29 ` Sven Eckelmann [this message]
2023-01-27 9:26 ` [PATCH v4 0/5] Implementation of a Stateless Multicast Packet Type Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2573733.TEPBkUXb7U@sven-desktop \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).