b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/batman-adv:remove unneeded variable
@ 2021-12-10  2:19 cgel.zte
  2021-12-10  7:49 ` Sven Eckelmann
  2021-12-10  7:52 ` Sven Eckelmann
  0 siblings, 2 replies; 5+ messages in thread
From: cgel.zte @ 2021-12-10  2:19 UTC (permalink / raw)
  To: mareklindner
  Cc: sw, a, sven, davem, kuba, b.a.t.m.a.n, netdev, linux-kernel,
	Minghao Chi, Zeal Robot

From: Minghao Chi <chi.minghao@zte.com.cn>

Return status directly from function called.

Reported-by: Zeal Robot <zealci@zte.com.cm>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 net/batman-adv/network-coding.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 0a7f1d36a6a8..0c300476d335 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -58,13 +58,9 @@ static int batadv_nc_recv_coded_packet(struct sk_buff *skb,
  */
 int __init batadv_nc_init(void)
 {
-	int ret;
-
 	/* Register our packet type */
-	ret = batadv_recv_handler_register(BATADV_CODED,
+	return batadv_recv_handler_register(BATADV_CODED,
 					   batadv_nc_recv_coded_packet);
-
-	return ret;
 }
 
 /**
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] net/batman-adv:remove unneeded variable
  2021-12-10  2:19 [PATCH] net/batman-adv:remove unneeded variable cgel.zte
@ 2021-12-10  7:49 ` Sven Eckelmann
  2021-12-10  7:52 ` Sven Eckelmann
  1 sibling, 0 replies; 5+ messages in thread
From: Sven Eckelmann @ 2021-12-10  7:49 UTC (permalink / raw)
  To: mareklindner, cgel.zte
  Cc: a, davem, kuba, b.a.t.m.a.n, netdev, linux-kernel, Minghao Chi,
	Zeal Robot

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

On Friday, 10 December 2021 03:19:17 CET cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return status directly from function called.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cm>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Applied after fixing obvious coding style problems.

Please try to fix the script which creates these automated patch submissions.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net/batman-adv:remove unneeded variable
  2021-12-10  2:19 [PATCH] net/batman-adv:remove unneeded variable cgel.zte
  2021-12-10  7:49 ` Sven Eckelmann
@ 2021-12-10  7:52 ` Sven Eckelmann
  2021-12-10  9:42   ` [PATCHv2] " cgel.zte
  1 sibling, 1 reply; 5+ messages in thread
From: Sven Eckelmann @ 2021-12-10  7:52 UTC (permalink / raw)
  To: mareklindner, cgel.zte
  Cc: a, davem, kuba, b.a.t.m.a.n, netdev, linux-kernel, Minghao Chi

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

On Friday, 10 December 2021 03:19:17 CET cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return status directly from function called.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cm>

And the Reported-by (robot) using a mail address which is bouncing.

   <zealci@zte.com.cm>: Host or domain name not found. Name service error for
       name=zte.com.cm type=AAAA: Host not found

Please fix this too in your scripts.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCHv2] net/batman-adv:remove unneeded variable
  2021-12-10  7:52 ` Sven Eckelmann
@ 2021-12-10  9:42   ` cgel.zte
  2021-12-10  9:51     ` Sven Eckelmann
  0 siblings, 1 reply; 5+ messages in thread
From: cgel.zte @ 2021-12-10  9:42 UTC (permalink / raw)
  To: sven
  Cc: a, b.a.t.m.a.n, cgel.zte, chi.minghao, davem, kuba, linux-kernel,
	mareklindner, netdev, sw, Zeal Robot

From: Minghao Chi <chi.minghao@zte.com.cn>

Return status directly from function called.
change since v1: zealci@zte.com.cm
             v2: zealci@zte.com.cn
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 net/batman-adv/network-coding.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 0a7f1d36a6a8..0c300476d335 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -58,13 +58,9 @@ static int batadv_nc_recv_coded_packet(struct sk_buff *skb,
  */
 int __init batadv_nc_init(void)
 {
-	int ret;
-
 	/* Register our packet type */
-	ret = batadv_recv_handler_register(BATADV_CODED,
+	return batadv_recv_handler_register(BATADV_CODED,
 					   batadv_nc_recv_coded_packet);
-
-	return ret;
 }
 
 /**
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCHv2] net/batman-adv:remove unneeded variable
  2021-12-10  9:42   ` [PATCHv2] " cgel.zte
@ 2021-12-10  9:51     ` Sven Eckelmann
  0 siblings, 0 replies; 5+ messages in thread
From: Sven Eckelmann @ 2021-12-10  9:51 UTC (permalink / raw)
  To: cgel.zte
  Cc: a, b.a.t.m.a.n, chi.minghao, davem, kuba, linux-kernel,
	mareklindner, netdev, Zeal Robot

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

On Friday, 10 December 2021 10:42:06 CET cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return status directly from function called.
> change since v1: zealci@zte.com.cm
>              v2: zealci@zte.com.cn
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---

This is wrong:

1. the patch was already applied
2. the patch history doesn't belong in the commit message
3. there is still an alignment problem
4. if you use -v in git-format-patch then it should be "PATCH v2" and not 
   "PATCHv2" (otherwise it will not be parsed correctly by patchwork)
5. The alignment problem is still there
6. the subject is also not following the normal formatting style

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-12-10  9:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-10  2:19 [PATCH] net/batman-adv:remove unneeded variable cgel.zte
2021-12-10  7:49 ` Sven Eckelmann
2021-12-10  7:52 ` Sven Eckelmann
2021-12-10  9:42   ` [PATCHv2] " cgel.zte
2021-12-10  9:51     ` Sven Eckelmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).