b.a.t.m.a.n.lists.open-mesh.org archive mirror
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: B.A.T.M.A.N. V - implement GW selection logic
Date: Mon, 13 Jun 2016 13:12:52 +0200	[thread overview]
Message-ID: <3127928.zeFBqT8Kuq@bentobox> (raw)
In-Reply-To: <20160612041426.26339-4-a@unstable.cc>

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

On Sunday 12 June 2016 12:14:25 Antonio Quartulli wrote:
> --- a/net/batman-adv/gateway_client.c
> +++ b/net/batman-adv/gateway_client.c
> @@ -215,6 +215,10 @@ void batadv_gw_election(struct batadv_priv *bat_priv)
>         if (!batadv_atomic_dec_not_zero(&bat_priv->gw.reselect) && curr_gw)
>                 goto out;
>  
> +       /* if gw.reselect is set to 1 it means that a previous call to
> +        * gw.is_eligible() said that we have a new best GW, therefore it can
> +        * now be picked from the list and selected
> +        */
>         next_gw = bat_priv->algo_ops->gw.get_best_gw_node(bat_priv);

I would guess that this should be either in patch 2/4 on in an extra patch. At
least it is about nothing which is touched otherwise in this patch

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-06-13 11:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-12  4:14 [B.A.T.M.A.N.] [PATCH v5 0/6] GW code: make it algorithm-agnostic and add B.A.T.M.A.N. V support Antonio Quartulli
2016-06-12  4:14 ` [B.A.T.M.A.N.] [PATCH v5 1/4] batman-adv: make the GW selection class algorithm specific Antonio Quartulli
2016-06-13 10:45   ` Sven Eckelmann
2016-06-13 16:02     ` Antonio Quartulli
2016-06-12  4:14 ` [B.A.T.M.A.N.] [PATCH v5 2/4] batman-adv: make GW election code protocol specific Antonio Quartulli
2016-06-13 11:45   ` Sven Eckelmann
2016-06-12  4:14 ` [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: B.A.T.M.A.N. V - implement GW selection logic Antonio Quartulli
2016-06-13 11:12   ` Sven Eckelmann [this message]
2016-06-13 16:02     ` Antonio Quartulli
2016-06-27  2:41     ` Antonio Quartulli
2016-06-13 11:26   ` Sven Eckelmann
2016-06-27  2:36     ` Antonio Quartulli
2016-06-27  6:19       ` Sven Eckelmann
2016-06-27  6:19         ` Antonio Quartulli
2016-06-13 11:45   ` Sven Eckelmann
2016-06-12  4:14 ` [B.A.T.M.A.N.] [PATCH v5 4/4] batman-adv: disable sysfs knobs when GW-mode is not implemented Antonio Quartulli
2016-06-13 10:47   ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3127928.zeFBqT8Kuq@bentobox \
    --to=sven@narfation.org \
    --cc=a@unstable.cc \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).