From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Prevent mutliple ARP replies sent by gateways in bla setups with dat enabled
Date: Mon, 15 Feb 2016 10:11:37 +0100 [thread overview]
Message-ID: <3296204.f5OVBeuHEA@bentobox> (raw)
In-Reply-To: <10971950.7jXMiP8m2i@prime>
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
On Monday 15 February 2016 09:50:18 Simon Wunderlich wrote:
> On Friday 12 February 2016 14:51:32 Andreas Pape wrote:
> > From 2b90abdf53e9ab09d9acfd141c7225de1ae16719 Mon Sep 17 00:00:00 2001
> > From: Andreas Pape <apape@phoenixcontact.com>
> > Date: Fri, 12 Feb 2016 10:05:57 +0100
> > Subject: [PATCH 1/4] batman-adv: Prevent mutliple ARP replies sent by
> > gateways in bla setups with dat enabled
> >
> > This patch shall make sure that only the backbone gw which has claimed the
> > remote
> > destination for the ARP request answers the ARP request directly if the
> > MAC address
> > is known due to the local DAT table. This prevents multiple ARP replies in
> > a common
> > backbone if more than one gateway already knows the remote mac searched
> > for in the
> > ARP request.
>
> This patch looks good in general. I can not apply it though, please check the
> links that Sven posted how to set up your mail client to send patches. Also,
> the commit message seems to have too long lines. Usually your git client
> should limit those to ~72 characters per line (I'm not sure about the actual
> limit)
See SubmittingPatches:
- The body of the explanation, line wrapped at 75 columns, which will
be copied to the permanent changelog to describe this patch.
This should also have been displayed when you've checked the patch with
Linux's
./scripts/checkpatch.pl --strict 000*.patch
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-15 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 13:51 [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: Prevent mutliple ARP replies sent by gateways in bla setups with dat enabled Andreas Pape
2016-02-12 14:47 ` Sven Eckelmann
[not found] ` <OFD4FAC06D.50E7ADCE-ONC1257F57.005D7B39-C1257F57.005FA7D8@phoenixcontact.com>
2016-02-12 17:36 ` [B.A.T.M.A.N.] Antwort: " Sven Eckelmann
2016-02-15 8:50 ` [B.A.T.M.A.N.] " Simon Wunderlich
2016-02-15 9:11 ` Sven Eckelmann [this message]
2016-02-15 9:39 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2016-02-15 10:08 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3296204.f5OVBeuHEA@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).