From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Fix Kconfig dependencies regarding multicast optimizations
Date: Thu, 30 Jun 2016 16:00:10 +0200 [thread overview]
Message-ID: <3504520.4WTWZUr9vM@bentobox> (raw)
In-Reply-To: <1467274165-2866-1-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
On Thursday 30 June 2016 10:09:25 Linus Lüssing wrote:
> Since recently the multicast optimizations are using functions from the
> bridge module. If batman-adv is a kernel built-in, then these bridge
> functions need to be accessible immediately. Thus adding a Kconfig
> dependency for the multicast optimizations to depend on batman-adv being
> built as a module if the bridge is built as a module, too.
[...]
> config BATMAN_ADV_MCAST
> bool "Multicast optimisation"
> - depends on BATMAN_ADV && INET
> + depends on BATMAN_ADV && INET && !(BRIDGE=m && BATMAN_ADV=y)
> default n
> help
> This option enables the multicast optimisation which aims to
The used functions are provided via stubs in include/linux/if_bridge.h when
bridge is disabled. So the symbols are only missing when the batman-adv code
is compiled as part of the kernel but the bridge code is compiled as modules.
So this change seems to make sense.
Reviewed-by: Sven Eckelmann <sven@narfation.org>
It is now part of the linux-merge.git.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-30 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 8:09 [B.A.T.M.A.N.] [PATCH] batman-adv: Fix Kconfig dependencies regarding multicast optimizations Linus Lüssing
2016-06-30 8:58 ` [B.A.T.M.A.N.] [fengguang.wu@intel.com: [batman:batman-adv/next 15/28] undefined reference to `br_multicast_has_querier_anywhere'] Linus Lüssing
2016-06-30 14:00 ` Sven Eckelmann [this message]
2016-07-05 8:05 ` [B.A.T.M.A.N.] [PATCH] batman-adv: Fix Kconfig dependencies regarding multicast optimizations Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3504520.4WTWZUr9vM@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).